Repository navigation
Jg/ignore failed scans - #1811
Open
JamesDoingStuff wants to merge 2 commits into
Open
JamesDoingStuff wants to merge 2 commits into
JamesDoingStuff wants to merge 2 commits into
Conversation
davehadley
approved these changes
Nov 9, 2026
| class TriggerWorkflow(BaseModel): | ||
| template: str | ||
| triggerOnMessageType: Literal["start", "stop"] | None = None | ||
| exitStatusWhitelist: list[str] |
Collaborator
There was a problem hiding this comment.
Would a better name be "triggerOnExitStatus"?
| "value": [workflow.triggerOnMessageType], | ||
| }) | ||
|
|
||
| if workflow.exitStatusWhitelist and source_type == "message-bus": |
Collaborator
There was a problem hiding this comment.
I know that you are following the pre-existing example of the triggerOnMessageType setting. But this design couples the Trigger CR interface strongly to the format of the message being emitted by the beamline.
Did you consider exposing "dataFilters" more directly to give consumers of this API more flexibility?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AP-1358
If a whitelist of scan message outcomes is specified, apply a filter on the Sensor. Outcome options taken from https://github.com/bluesky/event-model/blob/main/src/event_model/documents/run_stop.py