Repository navigation

Vulkan push constant support, based on #728 - #729

Closed

hzqst wants to merge 104 commits into

DiligentGraphics:inline_constantsfrom

hzqst:vk_push_constants

Closed

Vulkan push constant support, based on #728#729
hzqst wants to merge 104 commits into
DiligentGraphics:inline_constantsfrom
hzqst:vk_push_constants

Commits on Oct 19, 2025
Commits on Oct 20, 2025
Commits on Oct 22, 2025
Commits on Oct 23, 2025
Commits on Oct 24, 2025
Commits on Oct 25, 2025
- Add test for inline constants in render state cache
  TheMostDiligent
  committed
  2f706ee
Commits on Oct 26, 2025
Commits on Oct 27, 2025
Commits on Oct 30, 2025
- D3D11/D3D12: clean up code and update documentation for inline constants
  TheMostDiligent
  committed
  686f151
Commits on Oct 31, 2025
- Add tests for inline constants flag validation
  TheMostDiligent
  committed
  68a2c34
Commits on Dec 6, 2025
- Add vulkan inline constants support, emulated with uniform buffers. (PushConstants not impl yet)
  hzqst
  committed
  0324728
- fix formatting.
  hzqst
  committed
  a627e36
- fix formatting.
  hzqst
  committed
  f20c19e
- fix typo
  hzqst
  committed
  98bf219
- remove unused var
  hzqst
  committed
  437a562
Commits on Dec 7, 2025
- Add stuffs for vk push constants
  hzqst
  committed
  feed4cd
- Add PIPELINE_RESOURCE_FLAG_VULKAN_PUSH_CONSTANT to PRS so we don't to have to deal with SPIRVShaderResourceAttribs stuffs in PRS creation.
  hzqst
  committed
  f63da22
- fix formatting
  hzqst
  committed
  b8cddc6
- Fix emulated inline constant.
  hzqst
  committed
  1e3f54f
- Add missing tests
  hzqst
  committed
  5381581
- constexpr has ODR issue on ARM64, better go with macro.
  hzqst
  committed
  4354493
- fix formatting
  hzqst
  committed
  0899af0
- better flags check in ValidatePipelineResourceSignatureDesc
  hzqst
  committed
  de1d047
- update SetInlineConstants.md vulkan impl.
  hzqst
  committed
  c42471c
- update doc
  hzqst
  committed
  75ad2c3
- Fix testing
  hzqst
  committed
  d5cbc6d
- enable testing for vulkan
  hzqst
  committed
  1844c67
- Don't update revision, aligning to D3D11 inline constant behavior.
  hzqst
  committed
  869683a
- Fix m_HasInlineConstant not set when PRS restored from Render State Cache.
  hzqst
  committed
  1307ba8
- use vk staging buffer instead of dynamic buffer to avoid dynamic buffer id reuse issue.
  hzqst
  committed
  c4856ba
- Restore dynamic buffer, and skip buffer id verification
  hzqst
  committed
  9f796b6
Commits on Dec 8, 2025
- Fix issue when multiple inline constants using same pInlineConstantData.
  hzqst
  committed
  e030acc
- fix formatting
  hzqst
  committed
  0309087
- Fix PipelineResourceSignatureVkImpl::UpdateInlineConstantBuffers not updating dynamic buffer correctly.
  hzqst
  committed
  cbe779b
- fix formatting
  hzqst
  committed
  f523086
- Fix https://github.com/DiligentGraphics/DiligentCore/issues/730
  hzqst
  committed
  e2bbc2a
- Move pBuffer and pPushConstantData from PipelineResourceSignatureVkImpl to ShaderResourceCacheVk as per-SRB
  hzqst
  committed
  1a25e22
- Fix formatting
  hzqst
  committed
  1f18ab5
- Don't apply PIPELINE_RESOURCE_FLAG_NO_DYNAMIC_BUFFERS to SHADER_RESOURCE_VARIABLE_TYPE_MUTABLE.
  hzqst
  committed
  6a02357
- For some reason, pUncachedVS and pVS1 got same hash computation result on Vulkan.
  hzqst
  committed
  ad65b58
- Fix GetBindInfo() from DeviceContextVkImpl.cpp returning unexpected PIPELINE_TYPE_INVALID.
  hzqst
  committed
  00a01d9
- Fix formatting.
  hzqst
  committed
  617b449
- Fix ImmutableSamplers2 test when no resources provided in PRS Desc.
  hzqst
  committed
  17b7af5
- Fix formatting
  hzqst
  committed
  fb87222
- Skip CommitShaderResources for PRS that has no resources bound on it.
  hzqst
  committed
  af59a53
- Use ResIndex to locate actual InlineCB and PushConstantData.
  hzqst
  committed
  2574f04
- Fix formatting.
  hzqst
  committed
  693ca4e
Commits on Dec 9, 2025
- Rename GetInlineConstantBuffers to GetInlineConstantBufferAttribs to avoid confusion with actual buffer storage.
  hzqst
  committed
  8d57cdf
- Add PatchShaderConvertUniformBufferToPushConstant
  hzqst
  committed
  b882f3e
- Move buffervk to InlineConstantBufferAttribsVk, aligning to D3D11 impl.
  hzqst
  committed
  333c3d1
- Fix bad SRBCacheOffset.
  hzqst
  committed
  11b5918
- Remove PIPELINE_RESOURCE_FLAG_VULKAN_PUSH_CONSTANT, implement deferred push constant selection.
  hzqst
  committed
  fb2ecee
- bump SPIRV-Tools
  hzqst
  committed
  0708918
- fix formatting
  hzqst
  committed
  7f42a31
- restore test
  hzqst
  committed
  ac772fa
- restore tests
  hzqst
  committed
  e2accc3
- remove test code.
  hzqst
  committed
  a2bb192
- bump submodule
  hzqst
  committed
  2db3e63
Commits on Dec 10, 2025
- Now using pShaderResources from ShaderStageInfo instead of from ShaderVkImpl, allow updating SPIRVShaderResource with ShaderStageInfo on patching SPIRV simultaneously.
  hzqst
  committed
  c67819d
- fix formatting.
  hzqst
  committed
  475de54
- fix formatting.
  hzqst
  committed
  01daa97
- fix formatting
  hzqst
  committed
  9e813e4
- restore check in PRSBase
  hzqst
  committed
  e149356
- Allow empty ShaderResource.
  hzqst
  committed
  3fa0977
- restore SPIRV-Tools
  hzqst
  committed
  63411b2
- Port ConvertUBOToPushConstantPass to SPIRVTools.cpp
  hzqst
  committed
  d1e2ce3
- fix formatting
  hzqst
  committed
  9ebbadb
- Fix SPIRV-Tools headers warning
  hzqst
  committed
  9271f70
- restore SPIRV-Tools
  hzqst
  committed
  59a3c8f
- Fix formatting
  hzqst
  committed
  733ac6b
- restore #include "SPIRVTools.hpp"
  hzqst
  committed
  65f99b6
- We don't need TargetEnv in PatchSPIRVConvertUniformBufferToPushConstant
  hzqst
  committed
  56eb92d
- fiX not commit
  hzqst
  committed
  d0b19f1
- Fix error C3861: 'PatchSPIRVConvertUniformBufferToPushConstant': identifier not found
  hzqst
  committed
  7cfe7e4
- fix formatting.
  hzqst
  committed
  de856be
- We always need SPIRV-Tools to patch uniform buffer block, no matter NO_HLSL defined or not
  hzqst
  committed
  57b9bbf
- Enable SPIRV-Tools by default.
  hzqst
  committed
  1164bde
- restore CMakeLists.txt
  hzqst
  committed
  3520519
- Don't filter out SRBs that only have push constants (no descriptor sets), cuz we no longer filter out push constants when creating layout.
  hzqst
  committed
  c84f619
- throw err when SPIRV-Tools is not available. remove unused code.
  hzqst
  committed
  7a6a6c1
- fix formatting
  hzqst
  committed
  616e607