Repository navigation
Allow customizing Chrome page captures, sockets, and connections - #6
Open
stevebauman wants to merge 1 commit into
Open
stevebauman wants to merge 1 commit into
stevebauman wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added protected
createPageCapture()andcreateSocket()methods so custom Chrome drivers can replace page captures and sockets without copying the browser lifecycle code. Captures and shutdown now resolve sockets through the same method.Connection settings now flow through
getConnectionOptions()for browser startup, shared-browser reuse, headers, and shutdown. I've also documented the extension points with an example.Validated with 293 unit and feature tests, 7 real Chrome tests, and formatting checks.