Repository navigation
Customize captures with before callbacks and driver context - #8
Open
stevebauman wants to merge 5 commits into
Open
stevebauman wants to merge 5 commits into
stevebauman wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added
before()so you can customize a capture without creating a custom driver. Callbacks receive a driver-specific context implementingContracts\CaptureContext. Itsdriver()method returns the actual driver instance, so you can usematchorinstanceofwhen the customization depends on the driver.The Chrome context exposes
page()for the loaded browser page before image bounds are measured or PDF preparation begins. The Gotenberg context exposesrequest()for the prepared request before it's sent, with aset()method for multipart fields and access to its URL and Guzzle options.Custom drivers can implement the same context contract and expose their own resources. The hook is available on source, image, and PDF builders. Multiple callbacks run in registration order, output builders retain independent callback lists, and callback exceptions propagate through the existing cleanup.
Validated with 319 unit and feature tests, real Chrome capture tests, and Pint. Gotenberg request customization is verified using Guzzle's mock handler; its live service tests remain for CI.
This touches the Chrome capture construction also changed in #6, so those changes may need reconciling depending on merge order.