Repository navigation
ENG-2335 Add a shared check for whether an imported node is published to a group - #1512
Merged
mdroidian merged 2 commits intoOct 5, 2026
Conversation
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Devin Review found 3 potential issues.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
maparent
force-pushed
the
eng-2335-Add-a-shared-check-for-whether-an-imported-node-is-published-to-a-group
branch
from
October 2, 2026 21:24
5330315 to
60df351
Compare
maparent
force-pushed
the
eng-2335-Add-a-shared-check-for-whether-an-imported-node-is-published-to-a-group
branch
from
October 3, 2026 12:34
60df351 to
50cabfc
Compare
maparent
force-pushed
the
eng-2335-Add-a-shared-check-for-whether-an-imported-node-is-published-to-a-group
branch
from
October 3, 2026 12:41
50cabfc to
bda2ebc
Compare
3 tasks done
mdroidian
approved these changes
Oct 5, 2026
mdroidian
deleted the
eng-2335-Add-a-shared-check-for-whether-an-imported-node-is-published-to-a-group
branch
October 5, 2026 04:12
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/58
Reviewer brief
getPublishedGroupIdsByRidreturns, for each imported node RID, the user's groups that can read that node: groups withreaderoreditoraccess to its space, plus groups withpartialaccess and aResourceAccessgrant for the node.my_pseudo_accountsview, notSpaceAccess, because theSpaceAccessselect policy hidespartialrows. See the ticket comment.ResourceAccessbatch size is set from the group count so that a batch stays undermax_rows(1000). Rows from local ids that collide across a batch's spaces are not counted, and the hostedmax_rowsis assumed to matchsupabase/config.toml. Paging withgetAllPageswould remove both assumptions; I decided that it was adding scope, but it's certainly a reasonable thing to do.Verification
Unit tests.
One bug was found during ENG-2326 testing (last separate commit)
Loom video
Code walk
https://www.loom.com/share/59a52c0988d04de8952ffc0fde813b07
Scope check
Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
(Re-ran with the last commit)
https://linear.app/discourse-graphs/issue/ENG-2335/add-a-shared-check-for-whether-an-imported-node-is-published-to-a