Skip to content

Run roam, obsidian and database workflows when content-model changes - #1520

Open
MarkAlex1234 wants to merge 1 commit into
DiscourseGraphs:mainfrom
MarkAlex1234:ci/watch-content-model
Open

MarkAlex1234 wants to merge 1 commit into
DiscourseGraphs:mainfrom
MarkAlex1234:ci/watch-content-model

Conversation

@MarkAlex1234

@MarkAlex1234 MarkAlex1234 commented Oct 5, 2026 •

Copy link
Copy Markdown

Reviewer brief

  • Result: changes to packages/content-model (and types / utils where they apply) now trigger the workflows that build on them. Today they're skipped.
  • Why: @repo/database depends on @repo/content-model and @repo/utils, and apps/roam depends on @repo/content-model, @repo/database, @repo/types and @repo/utils (all workspace:*). The paths: filters predate content-model:
Workflow Added
roam-pr.yaml (preview deploy) packages/content-model/**, packages/types/**
roam-main.yaml (deploy) packages/content-model/**, packages/types/**
obsidian-main.yaml packages/content-model/** (via @repo/database)
test-database.yaml packages/content-model/**, packages/utils/**

content-model is actively changing (most recently in #1513). A PR that only touches packages/content-model currently gets no Roam preview and doesn't run the database tests, though both use the changed code.

  • Review focus: I deliberately left out packages/eslint-config and packages/typescript-config (dev tooling). Happy to add them if you want config changes to trigger these too.

Verification

All workflow YAML parses; 7 lines added, only inside paths:. I found the gaps by comparing each workflow's filters with the pnpm workspace graph (npx github:Continuous-Actions/dynamic-monorepo audit, a GitHub Action I maintain), then checked each against the package.json files. After this change, the only remaining findings are the two config packages above.


Devin Review

@repo/database depends on @repo/content-model and @repo/utils, and the roam app also depends on @repo/types, but roam-pr, roam-main, obsidian-main and test-database didn't watch those packages, so changes there skipped the preview, publish and database test runs.
@vercel

vercel Bot commented Oct 5, 2026

Copy link
Copy Markdown

@MarkAlex1234 is attempting to deploy a commit to the Discourse Graphs Team on Vercel.

A member of the Team first needs to authorize it.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

paths:
- "apps/obsidian/**"
- "packages/database/**"
- "packages/content-model/**"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Shared-package releases lose Linear tracking

For content-model-only pushes, obsidian-main publishes a beta without including the change in its Linear release. Its include_paths still excludes content-model; roam-main likewise excludes content-model and types after deploying them.

Learn more

The new push filters cause main-branch changes in shared packages to publish or deploy. The subsequent Linear syncs use separate path lists, which still exclude those packages in the Obsidian sync and the Roam sync. A change with no other matching paths therefore ships without its corresponding Linear release entry. The manual stable-release workflows reuse those older lists too.

Example: A merged PR changes only packages/content-model/src/schema/index.ts. Both main workflows run, but neither Linear sync includes that path, so the published builds lack that PR in their Linear release tracking.

Recommended fix: Add packages/content-model/** to Obsidian's Linear include_paths, and add both packages/content-model/** and packages/types/** to Roam's. Update the corresponding manual stable-release syncs to use the same paths.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant