Repository navigation
Run roam, obsidian and database workflows when content-model changes - #1520
MarkAlex1234 wants to merge 1 commit into
Conversation
@repo/database depends on @repo/content-model and @repo/utils, and the roam app also depends on @repo/types, but roam-pr, roam-main, obsidian-main and test-database didn't watch those packages, so changes there skipped the preview, publish and database test runs.
|
@MarkAlex1234 is attempting to deploy a commit to the Discourse Graphs Team on Vercel. A member of the Team first needs to authorize it. |
| paths: | ||
| - "apps/obsidian/**" | ||
| - "packages/database/**" | ||
| - "packages/content-model/**" |
There was a problem hiding this comment.
🟡 Shared-package releases lose Linear tracking
For content-model-only pushes, obsidian-main publishes a beta without including the change in its Linear release. Its include_paths still excludes content-model; roam-main likewise excludes content-model and types after deploying them.
Learn more
The new push filters cause main-branch changes in shared packages to publish or deploy. The subsequent Linear syncs use separate path lists, which still exclude those packages in the Obsidian sync and the Roam sync. A change with no other matching paths therefore ships without its corresponding Linear release entry. The manual stable-release workflows reuse those older lists too.
Example: A merged PR changes only packages/content-model/src/schema/index.ts. Both main workflows run, but neither Linear sync includes that path, so the published builds lack that PR in their Linear release tracking.
Recommended fix: Add packages/content-model/** to Obsidian's Linear include_paths, and add both packages/content-model/** and packages/types/** to Roam's. Update the corresponding manual stable-release syncs to use the same paths.
Was this helpful? React with 👍 or 👎 to provide feedback.
Reviewer brief
packages/content-model(andtypes/utilswhere they apply) now trigger the workflows that build on them. Today they're skipped.@repo/databasedepends on@repo/content-modeland@repo/utils, andapps/roamdepends on@repo/content-model,@repo/database,@repo/typesand@repo/utils(allworkspace:*). Thepaths:filters predate content-model:roam-pr.yaml(preview deploy)packages/content-model/**,packages/types/**roam-main.yaml(deploy)packages/content-model/**,packages/types/**obsidian-main.yamlpackages/content-model/**(via@repo/database)test-database.yamlpackages/content-model/**,packages/utils/**content-model is actively changing (most recently in #1513). A PR that only touches
packages/content-modelcurrently gets no Roam preview and doesn't run the database tests, though both use the changed code.packages/eslint-configandpackages/typescript-config(dev tooling). Happy to add them if you want config changes to trigger these too.Verification
All workflow YAML parses; 7 lines added, only inside
paths:. I found the gaps by comparing each workflow's filters with the pnpm workspace graph (npx github:Continuous-Actions/dynamic-monorepo audit, a GitHub Action I maintain), then checked each against thepackage.jsonfiles. After this change, the only remaining findings are the two config packages above.