Repository navigation
ENG-2368 Revoke write privileges on the my_spaces and my_accounts views - #1522
Merged
mdroidian merged 1 commit intoOct 7, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (eng-2368-revoke-write-privileges-on-the-my_spaces-and-my_accounts) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
mdroidian
approved these changes
Oct 7, 2026
mdroidian
deleted the
eng-2368-revoke-write-privileges-on-the-my_spaces-and-my_accounts
branch
October 7, 2026 14:41
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/70
Reviewer brief
my_spacesandmy_accountsget the revoke. Checkinginformation_schema.viewsfound them as the only automatically updatable views inpublicbesidesmy_concepts, which was already revoked. The other six views keep their default write grants but cannot be written through. ENG-2359 adds the revoke for (actually three of) its four views when its rewrite makes them updatable.Verification
features/readOnlyViews.feature(insert, update and delete through each view fail with42501; reads still return rows).INSERT,UPDATE,DELETEorTRUNCATEforanonorauthenticatedon any updatable view inpublic.pnpm ci:validatepasses.Loom video
https://www.loom.com/share/ff0770ca9b484183960f04a67a39f4c3
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: NoneStandards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2368/revoke-write-privileges-on-the-my-spaces-and-my-accounts-views