Repository navigation
ENG-2359 Speed up my_contents and the other access views to prevent plugin timeouts - #1523
Merged
maparent merged 1 commit intoOct 7, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (eng-2359-speed-up-my_contents-and-the-other-access-views-to-prevent) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
Base automatically changed from
eng-2368-revoke-write-privileges-on-the-my_spaces-and-my_accounts
to
main
October 7, 2026 14:41
mdroidian
approved these changes
Oct 7, 2026
maparent
force-pushed
the
eng-2359-speed-up-my_contents-and-the-other-access-views-to-prevent
branch
from
October 7, 2026 14:45
b48b8b9 to
00cc537
Compare
maparent
deleted the
eng-2359-speed-up-my_contents-and-the-other-access-views-to-prevent
branch
October 7, 2026 17:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/71
Reviewer brief
space_id <> own spacequeries onmy_contents,my_documentsand the embedding view go from 120–150 ms to 3–4 ms, including thedirectlisting query ofgetSharedNodeRows. Each query returns the same rows. The measurements are in the ticket comment.Done Whenlists it. It still joins two tables, so Postgres rejects writes through it with55000before it checks privileges, and a revoke changes nothing. This follows the ENG-2368 rule of revoking only on automatically updatable views. The ticket comment records the reason.dbTypes.tsgainsInsertandUpdatetypes formy_contents,my_documentsandmy_file_references. Type generation reads updatability, not grants, so these types describe writes that the revokes reject. The same happened formy_conceptsin ENG-2344.Verification
features/contentViewAccess.feature.pnpm ci:validatepasses.Loom video
https://www.loom.com/share/aef158e8a87d451ea73d79f092b035a1
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: NoneStandards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2359/speed-up-my-contents-and-the-other-access-views-to-prevent-plugin