ENG-2340 Import cross-space relations into Roam

[maparent]

https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/72

Reviewer brief

• Size: About 610 non-test lines, mostly in two files. Triple matching spans discovery (candidates and the match heuristic) and import (local-first steps), and neither half works alone: discovery stops rewriting Obsidian relations to triples, so import must resolve relation types in the same change. The refresh trigger and dialog fix are small but are what make the matching reachable from refresh.
• Review entry points: findOrImportRelationTriple in importSharedRelations.ts (steps 1–3), then the relation-type block in discoverSharedRelations.ts. The matching functions are reviewed in ENG-2373 Share the relation triple matching rule in packages/database #1527.
• Testing path: unit tests for each step, and a guard test that the shared default node type ids match Roam's defaults; the matching heuristic is tested in ENG-2373 Share the relation triple matching rule in packages/database #1527. Loom shows Done When 1, 2 and 4 with a hidden source node type. Done When 3 is unit-tested only.

Loom video

https://www.loom.com/share/3f7bd9edc333439ca1217a86c6e22023

Scope check

• Ran $scope-check against ENG-2340 and the final diff.

• Scope beyond Done When: Triple provenance and duplicate avoidance: a renamed local copy of the source triple is found by source identity, and a new triple records the source triple's RID when exactly one candidate matches. Candidates are picked with the shared matching rule from ENG-2373 (ENG-2373 Share the relation triple matching rule in packages/database #1527). Same-space Obsidian relations now go through the same local-first matching instead of the database exact match.

  • Required now: The ticket left the new triple's source identity open; without the renamed-copy lookup, a re-import creates a duplicate triple.
  • Anyone affected or consulted: Ticket owner.
  • Decision: https://linear.app/discourse-graphs/issue/ENG-2340/import-cross-space-relations-into-roam#comment-b4736483

• Scope beyond Done When: The space lookup in discoverSharedRelations now includes each relation's own space, for a relation between two nodes its space imported.

  • Required now: Not required by Done When; it prevents Missing space for that case.
  • Anyone affected or consulted: No
  • Decision: https://linear.app/discourse-graphs/issue/ENG-2340/import-cross-space-relations-into-roam#comment-375d48c6

• Scope beyond Done When: The discover dialog shows relation import failures in a separate warning.

  • Required now: The per-relation catch turns failures into a returned list; without the warning, failures the dialog used to report would only reach the log.
  • Anyone affected or consulted: No
  • Decision: https://linear.app/discourse-graphs/issue/ENG-2340/import-cross-space-relations-into-roam#comment-3c37f69c

Standards check

• Ran $dg-pr-adherence-check against the final diff and PR metadata.

Local delegated full review

• Ran a comprehensive review of the entire final diff in a subagent with a fresh context. Use $dg-delegated-full-review when no other full-review workflow is available.

Delegated review found:

• low (duplicate source RID on a second triple); fixed in the amended commit.
  Then (after rebase) :
• Medium, a failing schema still stops all relation imports, as before this change; follow-up issue candidate.
• Low, refresh warned about relations skipped for hidden schemas; fixed.
• Low, renaming a triple created without source identity duplicates it once; accepted, follows from the no-identity rule.

https://linear.app/discourse-graphs/issue/ENG-2340/import-cross-space-relations-into-roam

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
discourse-graph	Skipped		Oct 7, 2026 5:44pm UTC

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[linear-code]

ENG-2340

[devin-ai-integration]

Devin Review found 3 potential issues.