Repository navigation
ENG-2372 Record the source triple's RID on triples created by Obsidian relation import - #1526
Merged
maparent merged 1 commit intoOct 7, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Contributor
There was a problem hiding this comment.
Devin Review found 2 potential issues.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
maparent
force-pushed
the
eng-2372-record-the-source-triples-rid-on-triples-created-by-obsidian
branch
from
October 7, 2026 04:10
b7b99cd to
2167e26
Compare
maparent
changed the base branch from
main
to
eng-2373-share-the-relation-triple-matching-rule-in-packagesdatabase
October 7, 2026 04:10
maparent
force-pushed
the
eng-2373-share-the-relation-triple-matching-rule-in-packagesdatabase
branch
from
October 7, 2026 04:33
5d1b689 to
fc32c8c
Compare
maparent
force-pushed
the
eng-2372-record-the-source-triples-rid-on-triples-created-by-obsidian
branch
from
October 7, 2026 04:34
2167e26 to
bc921e2
Compare
Base automatically changed from
eng-2373-share-the-relation-triple-matching-rule-in-packagesdatabase
to
main
October 7, 2026 17:02
…n relation import
maparent
force-pushed
the
eng-2372-record-the-source-triples-rid-on-triples-created-by-obsidian
branch
from
October 7, 2026 17:08
bc921e2 to
dc415ea
Compare
maparent
deleted the
eng-2372-record-the-source-triples-rid-on-triples-created-by-obsidian
branch
October 7, 2026 17:47
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/75
Reviewer brief
sourceTriple.ts, so splitting them would ship that lookup without a user, or the repair without the fix that stops new bad triples.selectSourceTripleRidsinsourceTriple.ts, which picks the source triple (a Roam relation's schema is already the triple; an Obsidian relation's triple is matched with the shared rule from ENG-2373 Share the relation triple matching rule in packages/database #1527). ThenrepairImportedTripleRidsinrepairTripleRids.ts, which detects bad RIDs by therelationsubtype or by matching an imported instance's RID. Then the wiring inimportRelations.tsandinitializeSupabaseSync.isAcceptedSchematreat the imported triple as local, and sync would publish it as this space's own.mainbuild (Test -informs-> Question from an Obsidian space) and then repaired by this build. The Roam path is unit-tested only.Loom video
https://www.loom.com/share/17eeaf4cc9cc4096a26b8bb360b24f11
Scope check
Standards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.https://linear.app/discourse-graphs/issue/ENG-2372/record-the-source-triples-rid-on-triples-created-by-obsidian-relation