Skip to content

ENG-2380 Extract shared section header and align Foundations section width on landing page #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsmorabito wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENG-2380 Extract shared section header and align Foundations section width on landing page #1538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions apps/website/app/(home)/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { getAllBlogs } from "~/(home)/blog/readBlogs";
import { FoundationsSection } from "~/components/FoundationsSection";
import { Logo } from "~/components/Logo";
import { PlatformBadge } from "~/components/PlatformBadge";
import { SectionHeader } from "~/components/SectionHeader";
import { TeamPerson } from "~/components/TeamPerson";
import { TEAM_MEMBERS } from "~/data/constants";
import { STATIC_NEWS_ITEMS } from "~/data/news";
Expand Down Expand Up @@ -201,34 +202,6 @@ const SUPPORTERS: Supporter[] = [
},
];

type SectionHeaderProps = {
description?: string;
eyebrow: string;
isWide?: boolean;
title: string;
};

const SectionHeader = ({
description,
eyebrow,
isWide = false,
title,
}: SectionHeaderProps): ReactElement => (
<div className={isWide ? "max-w-none md:flex-1" : "max-w-3xl"}>
<p className="text-sm font-semibold uppercase tracking-[0.18em] text-secondary">
{eyebrow}
</p>
<h2 className="mt-3 text-3xl font-semibold tracking-tight text-primary sm:text-4xl">
{title}
</h2>
{description && (
<p className="mt-4 text-lg leading-8 text-neutral-dark/75">
{description}
</p>
)}
</div>
);

const ArrowLink = ({
children,
href,
Expand Down
10 changes: 6 additions & 4 deletions apps/website/app/components/FoundationsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { CSSProperties, ReactElement, ReactNode } from "react";
import Image from "next/image";
import { ScaledStage } from "~/components/ScaledStage";
import { SectionHeader } from "~/components/SectionHeader";

// Card size in the Figma frame; positions below use these coordinates.
const CARD_WIDTH = 570;
Expand Down Expand Up @@ -504,10 +505,11 @@ const ProtocolCard = (): ReactElement => (

export const FoundationsSection = (): ReactElement => (
<section className="bg-white px-5 pb-8 pt-16 sm:px-6 lg:pb-12 lg:pt-24">
<div id="foundations" className="mx-auto max-w-6xl scroll-mt-20">
<h2 className="text-3xl font-semibold tracking-tight text-primary sm:text-4xl">
Foundations
</h2>
<div id="foundations" className="mx-auto max-w-7xl scroll-mt-20">
<SectionHeader
eyebrow="Foundations"
title="A shared structure for research work in motion"
/>
<div className="mt-10 grid gap-8 md:grid-cols-2">
<NodesCard />
<RelationsCard />
Expand Down
31 changes: 31 additions & 0 deletions apps/website/app/components/SectionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import type { ReactElement } from "react";

type SectionHeaderProps = {
description?: string;
eyebrow?: string;
isWide?: boolean;
title: string;
};

export const SectionHeader = ({
description,
eyebrow,
isWide = false,
title,
}: SectionHeaderProps): ReactElement => (
<div className={isWide ? "max-w-none md:flex-1" : "max-w-3xl"}>
{eyebrow && (
<p className="mb-3 text-sm font-semibold uppercase tracking-[0.18em] text-secondary">
{eyebrow}
</p>
)}
<h2 className="text-3xl font-semibold tracking-tight text-primary sm:text-4xl">
{title}
</h2>
{description && (
<p className="mt-4 text-lg leading-8 text-neutral-dark/75">
{description}
</p>
)}
</div>
);
Loading