Skip to content

Fix guest shutdown snapshots and computer overlay rendering - #60

Merged
loki5512344ss merged 3 commits into
workfrom
fix/onyx-runtime
Oct 25, 2026
Merged

loki5512344ss merged 3 commits into
workfrom
fix/onyx-runtime

Conversation

@loki5512344ss

@loki5512344ss loki5512344ss commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Running guests could execute after the last CPU snapshot while mapped RAM kept changing, causing faults after reopening a world. Quiesce each server’s fully initialized computer/robot VMs before final persistence, retain their guest run state, and eagerly dirty joined computer chunks before Fabric’s pre-save unload discards lazy flags. The weak registry uses a private lock and releases it before waiting for workers.

The computer’s power/status overlay also bypassed sprite UV mapping through a fluent VertexConsumer call, drawing the entire block atlas over the terminal. Keep UV calls on the sprite wrapper; the regression exercises the real vanilla SpriteCoordinateExpander.

Validation: four shutdown regressions across six server targets (354 OC2R GameTests), 1,682 pre-overlay unit tests and main Checkstyle, plus three focused overlay regressions and main/test Checkstyle. Six live Onyx warm reloads compare every CPU register/CSR and all four RAM modules byte-for-byte, then require fresh guest/RAM/disk/RGB responses. A real Fabric 26.2 old-world control confirms the corrected world terminal image. CI reruns the complete checks on this head.

See docs/roadmap/onyx-runtime-followup.md and docs/roadmap/world-terminal-overlay-fix.md for evidence and limits. The separately committed OnyxKernel snapshot change is documented for coordination; bundled firmware and Sedna versions are unchanged.

@loki5512344ss loki5512344ss changed the title Fix guest state persistence during server shutdown Fix guest shutdown snapshots and computer overlay rendering Oct 25, 2026
@loki5512344ss
loki5512344ss marked this pull request as ready for review October 25, 2026 14:05
@loki5512344ss
loki5512344ss merged commit 93886c5 into work Oct 25, 2026
8 checks passed
@loki5512344ss
loki5512344ss deleted the fix/onyx-runtime branch October 26, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant