Repository navigation
Fix guest shutdown snapshots and computer overlay rendering - #60
Merged
Merged
Conversation
loki5512344ss
marked this pull request as ready for review
October 25, 2026 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running guests could execute after the last CPU snapshot while mapped RAM kept changing, causing faults after reopening a world. Quiesce each server’s fully initialized computer/robot VMs before final persistence, retain their guest run state, and eagerly dirty joined computer chunks before Fabric’s pre-save unload discards lazy flags. The weak registry uses a private lock and releases it before waiting for workers.
The computer’s power/status overlay also bypassed sprite UV mapping through a fluent VertexConsumer call, drawing the entire block atlas over the terminal. Keep UV calls on the sprite wrapper; the regression exercises the real vanilla SpriteCoordinateExpander.
Validation: four shutdown regressions across six server targets (354 OC2R GameTests), 1,682 pre-overlay unit tests and main Checkstyle, plus three focused overlay regressions and main/test Checkstyle. Six live Onyx warm reloads compare every CPU register/CSR and all four RAM modules byte-for-byte, then require fresh guest/RAM/disk/RGB responses. A real Fabric 26.2 old-world control confirms the corrected world terminal image. CI reruns the complete checks on this head.
See docs/roadmap/onyx-runtime-followup.md and docs/roadmap/world-terminal-overlay-fix.md for evidence and limits. The separately committed OnyxKernel snapshot change is documented for coordination; bundled firmware and Sedna versions are unchanged.