Repository navigation
Fix broken @stellar/stellar-sdk vitest mock — makes every PR look red #146
Description
Problem
Typecheck & build fails on main with:
Error: [vitest] No "Networks" export is defined on the "@stellar/stellar-sdk" mock.
Did you forget to return it from "vi.mock"?
Confirmed pre-existing rather than inferred: it fails identically on #137, which adds a single .md file and no code. A markdown-only PR cannot break a typecheck, so the failure is on main.
Why this matters more than one red check
Every open PR in the current batch shows a red Typecheck & build. Contributors can't tell whether they broke something, and reviewers start waving red checks through — which is exactly how a real failure eventually gets merged. A permanently-red required check is worse than no check, because it trains everyone to ignore the signal.
What to do
A vi.mock('@stellar/stellar-sdk', …) factory somewhere in the test suite returns a partial module that omits the Networks export, while some code path under test reads Networks.PUBLIC / Networks.TESTNET.
- Find the offending
vi.mockfactory. - Prefer spreading the real module over hand-listing exports, so future additions don't break it again:
Hand-maintained partial mocks of a large SDK re-break on every upgrade;
vi.mock('@stellar/stellar-sdk', async (importOriginal) => ({ ...(await importOriginal<typeof import('@stellar/stellar-sdk')>()), // ...only the specific overrides this test needs }))
importOriginaldoesn't. - Confirm
npm testis green on a cleanmainbefore closing.
Acceptance criteria
-
npm testpasses onmainwith no@stellar/stellar-sdkmock errors -
Typecheck & buildis green on a freshly-opened PR - Any remaining partial mocks of
@stellar/stellar-sdkuseimportOriginalspreading rather than a hand-listed export set
Drips Wave · Complexity: Easy · 100 points
Required: Before submitting, join the contributor Telegram so your work can be tracked and counted toward the Stellar Wave: https://t.me/+fxHXq8f1SwlkZDBk
Activity
Merge PR #139: parameterize Horizon and Soroban RPC clients per network
GiftedGiftB commentedon Aug 30, 2026
@GiftedGiftB has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @GiftedGiftB to this issue.
macsonfleek commentedon Aug 30, 2026
@macsonfleek has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @macsonfleek to this issue.
Gbolahan088 commentedon Aug 30, 2026
@Gbolahan088 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Gbolahan088 to this issue.
Ayodele06 commentedon Aug 30, 2026
@Ayodele06 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ayodele06 to this issue.
ghubmixxer commentedon Aug 30, 2026
@ghubmixxer has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @ghubmixxer to this issue.
Sureplus30 commentedon Aug 30, 2026
@Sureplus30 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Sureplus30 to this issue.
therealbibson commentedon Sep 23, 2026
@therealbibson has applied to work on this issue as part of the Stellar Wave Program's 9th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @therealbibson to this issue.
drips-wave commentedon Sep 23, 2026
Congratulations, @therealbibson! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.
🧑💻 @therealbibson: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
Miracle656 commentedon Sep 24, 2026
Closing as already fixed. Commits
041c2fcand7e2716aadded an explicitNetworks: { PUBLIC, TESTNET }override tobestRoute.test.tsandaggregator.property.test.ts, and the described failure no longer reproduces: fourteen consecutive full runs on main giveTests 400 passed | 1 skipped (401)withtsc --noEmitclean.Leaving this open was costing real contributor effort — PR #158 was written against it. Apologies to anyone who picked it up.
#151 is a different matter and is still real. I reproduced it three times, always in a full run, always passing in isolation, with rotating victims. An earlier check of mine got seven green runs and wrongly concluded it was fixed; that was luck, not evidence.
drips-wave commentedon Sep 24, 2026
This issue has been completed by @therealbibson as part of the Stellar Wave Program's 9th Wave 🥳
😎 @therealbibson: You earned 100 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.