Skip to content

feat(mcp): add pairs/pools/screener tools, upstream timeout guard, and docs (#409, #349, #422) - #452

Open
sparkysolutions10-pixel wants to merge 2 commits into
Divinity-Labs:mainfrom
sparkysolutions10-pixel:feat/mcp-tools-and-docs-409-349-422
Open

sparkysolutions10-pixel wants to merge 2 commits into
Divinity-Labs:mainfrom
sparkysolutions10-pixel:feat/mcp-tools-and-docs-409-349-422

Conversation

@sparkysolutions10-pixel

@sparkysolutions10-pixel sparkysolutions10-pixel commented Oct 17, 2026 •

Copy link
Copy Markdown

Summary

This PR implements three high-value open issues (#409, #349, #422) expanding the Model Context Protocol (MCP) server capabilities with market discovery tools, robust upstream error handling, and complete end-to-end documentation:

  1. Market Discovery MCP Tools (No tool exposes pairs, pools or the screener #409 - 150 pts):

    • Added lens_list_pairs, lens_get_pools, and lens_screen_pairs to BazaarMcpServer.
    • Shared query implementations directly with REST routes (/pairs, /pools, /screener) via extracted helpers (getPairsData, getPoolsData, getScreenerData), guaranteeing zero logic drift.
    • Bounded and paginated results (limit, offset / cursor) preventing context blowout for connected AI callers.
    • Enforced full asset issuer fidelity without string truncation across all results.
    • Distinct, functional descriptions guiding AI callers on when to use each tool.
  2. Upstream Call Robustness & Deadline Enforcement (The MCP server's upstream call has no deadline and no error handling #349 - 100 pts):

    • In bazaar_search, added a 10s deadline via AbortSignal.timeout(10_000) in fetchWithTimeout.
    • Explicitly validated HTTP status codes (rejecting non-2xx) and content-type (rejecting non-JSON) before parsing responses.
    • Return structured tool error (ERR_SERVICE_UNREACHABLE) naming the target upstream endpoint and exact failure reason.
  3. Complete Documentation & Client Agent Guide (The agent example is undocumented #422 - 100 pts):

    • Created examples/mcp-server/README.md documenting server startup (npm run mcp:server) and agent demo (npm run mcp:agent).
    • Prominently highlighted spending risks with real mainnet secret keys and documented testnet/read-only safe trial procedures.
    • Included a complete, runnable TypeScript client connection example using @modelcontextprotocol/sdk.
    • Linked MCP server documentation directly from root README.md alongside REST and GraphQL documentation.

Closes

Verification

  • npx vitest run tests/mcp.test.ts src/__tests__/envDrift.test.ts (17/17 tests passing)
  • npx vitest run src/__tests__/pools.test.ts src/__tests__/screener.test.ts (18/18 tests passing)
  • npx tsc --noEmit (0 type errors)
  • npm run build (build succeeds)

@Miracle656 Miracle656 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: one issue per PR, and only issues assigned to you

This is a process requirement, applied to all 23 of your open PRs in this repo. It is not a judgement about the code, which I have not been able to review — and that is the first half of the problem.

The bundling

Across your open PRs, 150 distinct issues are claimed. This one claims several. #483 claims 22, #481 claims 20, #477 claims 20, #474 claims 20.

A PR that closes twenty issues cannot be reviewed. Each of those issues has its own acceptance criteria — typically five — so twenty issues is a hundred separate things to verify in one diff, and if any one of them is wrong the whole PR is blocked while it is fixed. Every batch I published says the issues are deliberately independent so they can be worked in parallel, by different people, without colliding. Bundling them removes exactly that property.

The assignments

135 of the 150 issues claimed are assigned to other contributors — 67 different people.

This PR is an example: it names issues currently assigned to other contributors who are working on them now. Several have open PRs of their own. If this merged as it stands, those people would have done the work and received nothing for it, and I would have no way to tell the two efforts apart.

I am not assuming anything about why. Assignments change, Drips and GitHub can disagree, and a wide-ranging branch picks up issue numbers easily. But the effect on the people holding those assignments is the same regardless of intent, which is why I have to act on it.

What I need

  • One issue per PR. The issue number in the title, its acceptance criteria met, and nothing else in the diff.
  • Only issues assigned to you, or unassigned ones you have claimed through Drips. If an issue is assigned to someone else, it is theirs.
  • Re-open the work that meets both conditions as individual PRs. I will review them in the order they arrive and at the same pace as everyone else's.

Nothing is being closed. These stay open and are yours to re-cut, withdraw or split as you choose.

Two things worth knowing before you re-cut

Some of this has already landed. #488 (SSRF guard for bazaar_search) and #487 (the paid_call host allow-list) cover the same ground as your #449; #486 covers the MCP README. Check current main before rebuilding something that is already there.

main has moved a long way today — #306, #309, #252, #256, #355, #381, #390, #402, #476, #488 and more. Cut from current main, not from where these branches started.

If you believe an issue named here is genuinely yours, say which and I will check the assignment myself — I would rather be corrected than have someone lose work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No tool exposes pairs, pools or the screener The MCP server's upstream call has no deadline and no error handling The agent example is undocumented

2 participants