Repository navigation
feat(ws): prevent memory unbounded growth on slow WebSocket subscribers with backpressure buffer (#335) - #535
Closed
sparkysolutions10-pixel wants to merge 1 commit into
Conversation
…rs with backpressure buffer (Divinity-Labs#335)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #335
Summary of Changes
src/ws/fanout.tsbased on socketbufferedAmount.WS_BUFFER_THRESHOLD_BYTES, default 64KB): When a subscriber's buffer exceeds this threshold, intermediate price updates are coalesced and dropped to prevent memory queue growth, incrementingws_messages_dropped_total.WS_BUFFER_MAX_BYTES, default 1MB): Stalled peers exceeding this ceiling are terminated with WebSocket close code 1008 ("Buffer overflow") and unregistered, incrementingws_slow_clients_total.ws_messages_sent_totalupon confirmed write dispatch.src/__tests__/fanout.test.ts.