Repository navigation
feat(notifications): appointment booking notifications and reminders - #187
Micheal1605 wants to merge 12 commits into
Conversation
|
@Micheal1605 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
github-actions
Bot
added
the
needs-rebase
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared files like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@Micheal1605 CI is failing on this branch, so it can't be merged yet. The errors from the latest run: Backend (typecheck + test + build) Please reproduce this locally, fix the errors above and push. CI will re-run on your next push. This PR also has merge conflicts with |
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared files like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@Micheal1605 CI is failing on this branch against the latest Backend (typecheck + test + build) Reproduce this locally on the latest This PR also conflicts with |
github-actions
Bot
added
needs-rebase
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@Micheal1605 CI is failing on this branch against the latest Backend (typecheck + test + build) Reproduce this locally on the latest This PR also conflicts with |
github-actions
Bot
removed
the
needs-rebase
github-actions
Bot
added
the
needs-rebase
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@Micheal1605 CI is failing on this branch against the latest Backend (typecheck + test + build)
This PR also conflicts with |
github-actions
Bot
removed
the
needs-rebase
github-actions
Bot
added
the
needs-rebase
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
|
@Micheal1605 CI is failing on this branch against the latest Backend (typecheck + test + build)
|
|
@afeezorobsco-cyber — this PR is ready for another review. I resolved the merge conflicts with the main branch (pushed bc6c537). |
github-actions
Bot
removed
the
needs-rebase
|
@Micheal1605 CI is failing at The appointments service calls notification emitters that the PR doesn't export, and it uses an older |
github-actions
Bot
added
the
needs-rebase
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
…ons-booking Resolve docs/api/README.md: keep main's API reference and add this PR's reschedule row and Notifications section. The branch's copy of the file had a stray NUL byte (so git treated it as binary) and an older, partly garbled snapshot that would have dropped most of main's reference. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@Micheal1605 I resolved this PR's merge conflict with CI still fails on the same typecheck errors as before. The appointments service calls notification emitters that the notifications service doesn't export: Please pull the merge commit first ( |
github-actions
Bot
removed
the
needs-rebase
a0b4c0b to
46984de
Compare
|
@Micheal1605 Thanks for the notification fixes. After updating to
|
|
@afeezorobsco-cyber — this PR is ready for another review. I fixed the failing CI checks on this PR (pushed 42d79a0). |
github-actions
Bot
added
the
needs-rebase
|
@Micheal1605 This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared docs like Automated message. It won't repeat unless the PR conflicts again after your next push. |
42d79a0 to
ae247c8
Compare
🚨 Malware scan: needs security review@Micheal1605 The automated scan of
6 lower-severity note(s) for the reviewer
If this is a false positive, reply here explaining why and a maintainer will clear it. If it isn't intentional, remove it and push again: the scan re-runs on every push and updates this comment. |
github-actions
Bot
added
the
security-review
|
Warning Possible malicious code: please review before merging. An automated security scan flagged files in this pull request that appear to contain malicious code. Code like this can run automatically when a project is opened in an editor or its dependencies are installed, so it could compromise the machine of anyone who checks out this branch. Automated scans can be wrong, so this may be a false positive. Maintainers: please review the flagged files carefully before merging, on GitHub in your browser rather than by checking out the branch. The malicious part is often hidden far off to the right of an ordinary-looking line, so scroll sideways through each file. @Micheal1605: this pull request adds or changes these files, possibly without your knowledge. Malware like this spreads by adding itself to repositories on machines it has infected, so your machine might be compromised. Please undo these changes in this pull request, and don't open or run other projects on that machine until you've checked it. Flagged files at commit
Only merge once you're confident these files are safe. ℹ️ Posted automatically by Drips Wave. Questions? Contact support@drips.network. |
Overview
This PR wires appointment booking events into the notification pipeline. When a booking commits, booking-confirmed (patient) and new-booking (doctor) notifications are emitted through the outbox, and a reminder job sends 24h and 2h reminders that are idempotent per appointment and reminder type. Cancellation and reschedule notifications are sent to the other party, and reminder sends check appointment state at send time so cancelled or rescheduled appointments are suppressed.
Related Issue
Changes
🔔 Notification services and repositories
[MODIFY]
backend/src/modules/notifications/services/index.ts[MODIFY]
backend/src/modules/notifications/repositories/index.ts📅 Appointment services
backend/src/modules/appointments/services/index.ts📚 Docs
docs/api/README.mdROADMAP.mdVerification Results
Closes #98