refactor: adopt EAFP and explicit error handling for template file - #45
Open
Stephen0512 wants to merge 2 commits into
Open
refactor: adopt EAFP and explicit error handling for template file#45Stephen0512 wants to merge 2 commits into
Stephen0512 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified Issues
The current
DomainConnect.__init__usesos.access()to check file permissions before opening, which creates a security risk due to race conditions. The Python documentation recommends using EAFP (Easier to Ask for Forgiveness than Permission) link to avoid this.Proposed Changes
os.access()and other pre-checks with EAFP by directly attempting to open the file and catching exceptions.FileNotFoundError,PermissionError) with clear messages.The issue was identified during an ongoing research project.