Add EmailWish maileremailwish.com.cmarketing template - #1698
Open
ankit662002 wants to merge 1 commit into
Open
ankit662002 wants to merge 1 commit into
ankit662002 wants to merge 1 commit into
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|
ankit662002
marked this pull request as ready for review
August 30, 2026 14:37
PR Description Check PassedAll required sections are filled in correctly. Details |
pawel-kow
requested changes
Sep 2, 2026
| "type": "NS", | ||
| "host": "%nsHost%", | ||
| "ttl": 3600, | ||
| "pointsTo": "%nsTarget1%" |
Member
There was a problem hiding this comment.
Aren't the nameservers ns1.maileremailwish.com something possible to fix in the template or narrow down to %var%.maileremailwish.com or similar construct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New Domain Connect template for EmailWish marketing DNS setup (providerId=maileremailwish.com, serviceId=cmarketing).
Applies:
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set - this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain- the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") - use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC)@ TXT "%foo%") unless necessary - prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel - the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR descriptionhostfield to create a subdomain - use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC)Justifications
%txtData%as TXT value: ownership verification tokens are externally prescribed and cannot carry a fixed prefix.%txtHost%/%nsHost%as host labels: this template must write a verification TXT and subdomain NS at different labels in one apply. The protocolhostparameter would prefix all records the same way, so per-record host variables are required. Labels are supplied by EmailWish (e.g. cmarketing, ew), not end-user freeform input.essential/ OnApply: N/A for verification TXT + NS delegation records; they are the service itself.Online Editor test results
Editor test link(s):
Test maileremailwish.com/cmarketing example.com/@
Test maileremailwish.com/cmarketing example.com/www