Skip to content

Add EmailWish maileremailwish.com.cmarketing template - #1698

Open
ankit662002 wants to merge 1 commit into
Domain-Connect:masterfrom
ankit662002:emailwish-cmarketing
Open

ankit662002 wants to merge 1 commit into
Domain-Connect:masterfrom
ankit662002:emailwish-cmarketing

Conversation

@ankit662002

@ankit662002 ankit662002 commented Aug 30, 2026

Copy link
Copy Markdown

Description

New Domain Connect template for EmailWish marketing DNS setup (providerId=maileremailwish.com, serviceId=cmarketing).

Applies:

  • A verification TXT record (%txtHost% / %txtData%)
  • Two subdomain NS records for delegated marketing DNS (%nsHost% to %nsTarget1% / %nsTarget2%) — not apex NS changes

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

  • Template functionality checked using Online Editor
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.

  • syncPubKeyDomain is set - this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejected
  • warnPhishing is not set alongside syncPubKeyDomain - the two must not appear together
  • syncRedirectDomain is set whenever the template uses redirect_uri in the synchronous flow
  • no TXT record contains SPF content ("v=spf1 ...") - use the SPFM record type instead
  • txtConflictMatchingMode is set on every TXT record that must be unique per label or content prefix (e.g. DMARC)
  • no variable is used as a bare full record value (e.g. @ TXT "%foo%") unless necessary - prefer @ TXT "service-foo=%foo%"; if bare, justify in the PR description
  • no bare variable is used as the full host label - the non-variable parts are fixed to limit misuse (e.g. %dkimkey%._domainkey, not %dkimhost%); if bare, justify in the PR description
  • no variable is used in the host field to create a subdomain - use the host parameter or multiInstance instead
  • %host% does not appear explicitly in any host attribute
  • essential is set to OnApply on records the end user may need to modify or remove without breaking the template (e.g. DMARC)

Justifications

  • Bare %txtData% as TXT value: ownership verification tokens are externally prescribed and cannot carry a fixed prefix.
  • Bare %txtHost% / %nsHost% as host labels: this template must write a verification TXT and subdomain NS at different labels in one apply. The protocol host parameter would prefix all records the same way, so per-record host variables are required. Labels are supplied by EmailWish (e.g. cmarketing, ew), not end-user freeform input.
  • essential / OnApply: N/A for verification TXT + NS delegation records; they are the service itself.

Online Editor test results

Editor test link(s):

Test maileremailwish.com/cmarketing example.com/@

Test maileremailwish.com/cmarketing example.com/www

@github-actions github-actions Bot added PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Aug 30, 2026
@github-actions

Copy link
Copy Markdown

JSON Filename Check Passed

@github-actions

Copy link
Copy Markdown

JSON Schema Validation Passed

@github-actions

Copy link
Copy Markdown

Linter OK

maileremailwish.com.cmarketing.json

Level Code Note

@ankit662002
ankit662002 marked this pull request as ready for review August 30, 2026 14:37
@github-actions github-actions Bot removed PR description incomplete The PR description template was not filled in at all, altered or filled in improperly. Test links missing No test links from Online Editor provided labels Aug 30, 2026
@github-actions

Copy link
Copy Markdown

PR Description Check Passed

All required sections are filled in correctly.

Details
  OK  Type of change: 1/4 checkboxes ticked
  OK  How Has This Been Tested?: all 3 checkboxes ticked
  OK  Checklist of common problems: 10/10 checkboxes ticked
  OK  Online Editor test results: 2 link(s) found
  OK  Template coverage: all 1 template(s) covered
Labels to remove: Checklist of common problems not complete, Forged editor links, PR description incomplete, Test links missing

PR description check PASSED

"type": "NS",
"host": "%nsHost%",
"ttl": 3600,
"pointsTo": "%nsTarget1%"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the nameservers ns1.maileremailwish.com something possible to fix in the template or narrow down to %var%.maileremailwish.com or similar construct?

@github-actions github-actions Bot added the review issues Changes requested from PR review label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review issues Changes requested from PR review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants