update Loot OS storefront: DKIM CNAMEs move under mail. (version 2) - #1813
Merged
pawel-kow merged 2 commits intoSep 14, 2026
Merged
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
PR Description Check PassedAll required sections are filled in correctly. Details |
Linter OK
|
| Level | Code | Note |
|---|---|---|
| info | DCTL1021 | missing from iana definitions |
pawel-kow
approved these changes
Sep 14, 2026
|
Thanks @dylanclootlabs for contributing to the template. 🎉 This template has been reviewed and merged by @pawel-kow. 🙌 This template repository and its review process are maintained by independent individuals in their spare time, not as part of a paid role. If you or your company benefit from this protocol and its tools, please show your appreciation by buying a beer for @pawel-kow: https://github.com/sponsors/pawel-kow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
lootos.com.storefront.jsonto version 2. The three Amazon SES Easy DKIM CNAMEs move from%dkimN%._domainkey(on the storefront hostname itself) to%dkimN%._domainkey.mail, and the storefront's sign-in emails now come fromno-reply@mail.<hostname>instead ofno-reply@<hostname>. The description and variable description say so; nothing else changes (records for the storefront CNAME and the_cf-challengeTXT are identical to version 1).Reason: version 1 put the DKIM selectors under the hostname's own
_domainkey, which is where a customer's existing mail on that hostname keeps its selectors. Scoping the sender to themail.subdomain keeps Loot OS records away from whatever mail the customer already runs. Records applied from version 1 are plain CNAMEs to*.dkim.amazonses.comand stay harmless; the version bump makes providers refetch the template.Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC)@ TXT "%foo%") unless necessary — prefer@ TXT "service-foo=%foo%"; if bare, justify in the PR descriptionhostlabel — the non-variable parts are fixed to limit misuse (e.g.%dkimkey%._domainkey, not%dkimhost%); if bare, justify in the PR descriptionhostfield to create a subdomain — use thehostparameter ormultiInstanceinstead%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC)Comments (unchanged from #1749):
_cf-challengeTXT carries%endpoint%on its own because CloudFront prescribes the exact record content (the distribution's routing endpoint) for its hostname ownership check; a prefix would make the check fail. It is scoped by its fixed_cf-challengelabel andtxtConflictMatchingMode: All, so a stale value from an earlier attempt is replaced rather than accumulated.essential: not set on any record on purpose. All five records are required as-is for the storefront and its sender to work; there is none a user would need to edit independently.hostvalues keep their fixed._domainkey.mailsuffix; the variable is still only the selector.Online Editor test results
Editor test link(s):
Test lootos.com/storefront example.com/shop