Repository navigation
fix: Libass fallback font name fix - #1157
Merged
PartyDonut merged 1 commit intoOct 25, 2026
Merged
Conversation
Drun555
changed the title
Drun555
marked this pull request as ready for review
September 30, 2026 20:00
PartyDonut
approved these changes
Oct 25, 2026
PartyDonut
left a comment
PartyDonut
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
PlayerConfigurationrequires bothlibassAndroidFontandlibassAndroidFontNamebefore it extracts the asset and configures mpv'ssub-fonts-dir/sub-font. Fladder previously supplied only the asset path, so external ASS tracks were downloaded and selected but could render no glyphs on Android devices without a usable font provider.My debug build logs showed the external track loading successfully (
codec=ass,sid=1,sub-ass=yes) followed by:So, yes.
Issue Being Fixed
This PR fixes external .ass rendering with MPV and libass enabled on Android.
I didn’t open a separate issue and proactively submitted this PR. This issue is, however, is very familiar with #1077 - but on a different path.
Screenshots / Recordings
Not applicable; this is a player configuration fix.
Tested On
Tested on a OnePlus tablet with an external .ass delivered by Jellyfin.
Checklist