Repository navigation
test(fix): wait for launch arguments in menu interaction tests - #86
Merged
Merged
Conversation
The menu interaction tests polled for about one second after each launch and then read the shim's marker file with a throwing call. On a loaded machine the shim took longer, so the read raised NSCocoaErrorDomain 260 at top level and the binary died with Trace/BPT trap 5. A shared helper now clears the marker, runs the launch and polls for up to 10 seconds until the menu has closed and the marker has content. The menu closes only after the launch process exits, so those two together mean the arguments are complete. A timeout reports a named expectation instead of an uncaught error. The two alert-toggle waits use the same bounded poll. The normal run still finishes in about 4 seconds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The updated waits have bounded completion checks, and the alert tests report which behavior failed. No issue identified here needs to block merging. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: updating menu interaction tests to wait for launch arguments. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MenuInteractionTestspolled for about 1 second after each launch (for _ in 0..<100 where !closed) and then read the shim's marker withtry String(contentsOf:). On a loaded machine the shim took longer than that, so the read threwNSCocoaErrorDomain Code=260at top level andtest/macos/menu-app-test.shdied withTrace/BPT trap 5. This pattern came in with #75.launchArguments(recordedIn:until:_:launch:)helper clears the marker, runs the launch, then polls every 10 ms for up to 10 seconds until the menu has closed and the marker has content. The menu closes only after the launch process exits, so both conditions together mean the arguments are complete. Clearing the marker first stops a wait from reading the previous launch's arguments.expectfailure (for example,a profile launch must dismiss the menu and record its arguments within 10 seconds) instead of an uncaught error.waitUntilwith the same 10-second bound.The change is test-only, so there is no CHANGELOG entry.
Verification
bash test/macos/menu-app-test.shpasses.make checkpasses (exit 0).sleep 2to the shim in scratch copies (not committed):Code=260 … "launch" couldn’t be opened.Fatal error: a profile launch must dismiss the menu and record its arguments within 10 seconds.🤖 Generated with Claude Code
Summary by CodeRabbit