Repository navigation
frontend(feat): refine the menu's typography and row rhythm - #92
Merged
Merged
Conversation
Give the menu-bar popover one type scale in which weight, not size, carries the hierarchy: 13-point semibold title, 13-point medium row names, 11-point secondary details and 11-point semibold headings. - Every available row is 48 points high (unavailable rows 64), instead of 44 for profiles and 56 for workspaces. - Profiles show a monogram disc and workspaces a folder, pin or missing folder tile, replacing identical person symbols. - Hover and keyboard selection paint an inset, rounded plate with a faint label-colour outline, full strength under Increase Contrast. - Rules divide rows only within a group, start at the title column and hide beside a highlighted row; space above headings separates groups. - The quota column sets a smaller, quieter percent sign beside tabular figures. - The header mark, title, row marks and names share columns; one rule now sits under the filters rather than under the title. Tests follow the new row heights, inset rules and highlight plate, and check that a rule steps aside beside the selection. Previews, DESIGN.md and the site's preview height are regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 7.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 2 files. (3 skipped: 3… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main changes to the menu typography, spacing, and row layout. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 7.41% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 27 functions across 2 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The menu-bar popover had little visual hierarchy: the title, row names, group headings and quota figures were all bold, rows were uneven heights, and full-width separators doubled up with section headings. This PR refines its typography, spacing and row styling without changing behaviour.
DESIGN.md, both committed previews, the site's preview
height(478 → 490) and the## Unreleasedchangelog are updated.Testing
make checkon macOS: syntax, behaviour, packaging, native macOS tests and ShellCheck, all passing.MenuInteractionTestsnow checks 48/64-point rows, one in-group rule aligned with the title column and trailing inset, that the rule beside the selected row hides and returns, and the selection outline, fill and appearance changes on the new highlight plate.Scope and compatibility
Checklist
make check; if the environment lacks ShellCheck, I ranmake testand documented the missing lint result instead.or migrates auth tokens or ChatGPT cookies.
app defaultsession and use theoriginal signed app bundle. (No launch changes in this PR.)
🤖 Generated with Claude Code
Summary by CodeRabbit