Alrodri/samples verification and cleanup - #377
Merged
Merged
Conversation
…ties because they're deprecated. Started updating some projects to make running them easier.
… Aspire's CLI Bundling that we were ignoring anyway. Added a nuget.config file to also remove some warnings.
ProgrammerAL
requested review from
RolandGuijt,
khalidabuhakmeh,
maartenba and
wcabus
August 20, 2026 20:15
ProgrammerAL
added
bug
maartenba
approved these changes
Aug 21, 2026
maartenba
left a comment
maartenba
left a comment
Member
There was a problem hiding this comment.
Amazing work, @ProgrammerAL ! I think the one README that is off is one to fix, other comments just for consideration. Approving so you can merge after README update.
Collaborator
|
348 files... LGTM 🥳 |
Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet formatto ensure C# code follows rules set in .editorconfig. Plus added manual fixes in places like file header or spacing.Skipped verification of:
For task: https://github.com/DuendeSoftware/customer-success/issues/875