Alrodri/update v7 samples with readmes and aspire - #378
Open
ProgrammerAL wants to merge 2 commits into
Open
Conversation
…bled projects in some v7 samples and v8.
…xed some compiler warnings.
maartenba
approved these changes
Aug 29, 2026
maartenba
left a comment
maartenba
left a comment
Member
There was a problem hiding this comment.
Small cosmetic suggestion, otherwise looks great!
Comment on lines
+100
to
+101
| //Sometimes the app closes before the Aspire console receives all output | ||
| // Delay to ensure output makes it to the console |
Member
There was a problem hiding this comment.
Suggested change
| //Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console | |
| // Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console |
Comment on lines
+133
to
+134
| //Sometimes the app closes before the Aspire console receives all output | ||
| // Delay to ensure output makes it to the console |
Member
There was a problem hiding this comment.
Suggested change
| //Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console | |
| // Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console |
Comment on lines
+120
to
+121
| //Sometimes the app closes before the Aspire console receives all output | ||
| // Delay to ensure output makes it to the console |
Member
There was a problem hiding this comment.
Suggested change
| //Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console | |
| // Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console |
Comment on lines
+122
to
+123
| //Sometimes the app closes before the Aspire console receives all output | ||
| // Delay to ensure output makes it to the console |
Member
There was a problem hiding this comment.
Suggested change
| //Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console | |
| // Sometimes the app closes before the Aspire console receives all output | |
| // Delay to ensure output makes it to the console |
wcabus
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdentityServer v7 work for https://github.com/DuendeSoftware/customer-success/issues/875