Allow retrying failed run-step skips - #476
Merged
adamruzicka merged 1 commit intoSep 25, 2026
Merged
Conversation
adamruzicka
approved these changes
Sep 25, 2026
adamruzicka
left a comment
adamruzicka
left a comment
Contributor
There was a problem hiding this comment.
This is fine, that one failing test should be addressed on master already
Contributor
|
Thank you @jakduch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390
When skipping a failed run step also fails, its finalize step is already marked as skipped. Retrying the recovery currently attempts the invalid
skipped -> skippedtransition and leaves the execution plan unrecoverable.Make
FinalizeStep#mark_to_skipidempotent and cover retrying the failed skip with a regression test.Verified with:
bundle exec ruby -Itest test/rescue_test.rbbundle exec rubocop lib/dynflow/execution_plan/steps/finalize_step.rb test/rescue_test.rbbundle exec rake teston Ruby 3.3 / SQLite (403 runs, 1491 assertions)