Conversation
jakduch
force-pushed
the
fix/433-orphaned-planning
branch
from
September 26, 2026 11:42
9463f10 to
ed2f069
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433
Execution plans can remain in
planningforever when their planning lock is missing. Existing invalidation only recovers plans whose lock is owned by a world that no longer exists.Extend the validity check to find planning plans without a corresponding planning lock. Recovery first acquires a replacement planning lock, reloads the plan, and only then changes its state, preventing concurrent validity checks or an active planner from racing the recovery. Fully planned plans continue to execution; incomplete plans are stopped.
Verified with:
bundle exec ruby -Itest test/abnormal_states_recovery_test.rb(25 runs, 69 assertions)bundle exec rubocop lib/dynflow/world/invalidation.rb test/abnormal_states_recovery_test.rbbundle exec rake teston Ruby 3.3 / SQLite (404 runs, 1489 assertions)