[janishorsts]

Earthly accidentally added the x/net/context (instead of the std context) import.

Summary by CodeRabbit

• Compatibility
  • Socket forwarding now uses Go’s standard context types. Applications that explicitly rely on the former golang.org/x/net/context package may need to update their callers.
  • The vendored legacy context package is no longer included, so its types and helper functions are unavailable through this package.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 67a035f5-db8a-4e36-8441-f08e43b14680

📥 Commits

Reviewing files that changed from the base of the PR and between 3ad5cdf and 558ae00.

📒 Files selected for processing (9)

• AGENTS.md
• session/socketforward/copy.go
• session/socketforward/socket.go
• vendor/golang.org/x/net/context/context.go
• vendor/golang.org/x/net/context/go17.go
• vendor/golang.org/x/net/context/go19.go
• vendor/golang.org/x/net/context/pre_go17.go
• vendor/golang.org/x/net/context/pre_go19.go
• vendor/modules.txt

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7a00d874-d46e-468d-9f89-0327ee4ca24b

📥 Commits

Reviewing files that changed from the base of the PR and between d14db0e and 3ad5cdf.

📒 Files selected for processing (1)

• AGENTS.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The socketforward package now uses the standard-library context package, and Copy accepts its context.Context type. The vendored golang.org/x/net/context package and its vendor manifest entry were removed. AGENTS.md now describes the repository and provides guidance for code changes.

Changes

Context migration

Layer / File(s)	Summary
Use standard-library context session/socketforward/copy.go, session/socketforward/socket.go	Both files now import the standard-library context package. Copy now accepts the standard-library context.Context type.
Remove vendored context package vendor/golang.org/x/net/context/*, vendor/modules.txt	The vendored context implementations and the package entry in vendor/modules.txt were removed.

Repository guidance

Layer / File(s)	Summary
Add repository context and change guidance AGENTS.md	The file identifies the repository as a fork, names its primary use, and asks that code changes remain minimal.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 3ad5c

The context migration matches repository callers and supported Go versions, and removing the vendored package leaves no in-repository Go imports unresolved. No actionable merge-blocking risk is established.

Architecture Summary

Architecture risk: 🔵 Low · up to ecee3

The change affects 1 system.

Changed systems: session

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — session (service) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in session/socketforward/copy.go: The imports now use the standard library context package; the golang.org/x/net/context import was removed. Consequently, Copy uses the standard library context type.
• observed — Modified behavior in session/socketforward/socket.go: Replaced the golang.org/x/net/context import with the standard-library context import; the other imports in this range remain unchanged.
• observed — Modified behavior in vendor/golang.org/x/net/context/context.go: The deleted file defined the golang.org/x/net/context package, documented context propagation and usage rules, and exported Background() and TODO() functions returning the corresponding empty contexts.
• observed — Modified behavior in vendor/golang.org/x/net/context/go17.go: The Go 1.7 build-tagged file was deleted, removing its standard-library-backed context error variables and wrappers for cancellation, deadlines, timeouts, and values.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: migrating socketforward from golang.org/x/net/context to the standard-library context package.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch	Total Count
main	219
This PR	219
Difference	+0

---

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

[kmannislands]

@janishorsts change LGTM but looks like your commit signing didn't work here according to github?