Repository navigation
fix(ui-snapshots): keep fast UI loop buildable - #317
Merged
Merged
Conversation
- add CaretPlacement.swift and LearningHints.swift to snapshot source lists - add test-ui-snapshots.py so drift fails offline regression - make macos-ui-snapshots renders candidate/panels/HUD again (report 286) Signed-off-by: wangzhizhou <824219521@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
make macos-ui-snapshots因CandidateWindow新增CaretPlacement/LearningHints依赖而编译失败；补全快照源码清单；test-ui-snapshots.py，清单再漂移会在离线回归里红；make macos-dev/ 离线回归 / 换包验收）。验证
make macos-ui-snapshotsPASS（候选 6 / 面板 14 / HUD 6）make macos-offline-tests68 文件 / 337 例 PASSmake verifyPASS（542 产物零网络符号）