Repository navigation
feat: add Surcharges to Rate model - #230
Merged
Merged
Conversation
Justin Hammond (Justintime50)
marked this pull request as draft
August 7, 2024 19:28
Member
Author
|
Going to close until needed |
Justin Hammond (Justintime50)
changed the title
1 of 4 tasks
Justin Hammond (Justintime50)
force-pushed
the
surcharges
branch
from
October 1, 2026 16:15
d4d0abb to
1024ffd
Compare
Justin Hammond (Justintime50)
marked this pull request as ready for review
October 1, 2026 16:15
Justin Hammond (Justintime50)
changed the title
Removed surcharge category detail from changelog entry.
Stephen Watkins (stephenjwatkins)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revives and rebases this PR onto current
masterand adds surcharge support on rates.Changes in this PR:
Surchargesto theRatemodelCategoryto theSurchargemodel (categoryJSON field)Next Releasesection at the top of the changelogTesting
go test ./... -run TestRateUnmarshalSurchargeCategory -count=1(compile/selection check)go test ./... -count=1(fails in local environment due to missing test API fixtures/API key; unrelated to this change)Pull Request Type