Repository navigation
ci: don't persist GITHUB_TOKEN in checkout (SEC-844) - #290
Draft
Matt Sutkus (msuitcase) wants to merge 1 commit into
Draft
Matt Sutkus (msuitcase) wants to merge 1 commit into
Matt Sutkus (msuitcase) wants to merge 1 commit into
Conversation
actions/checkout writes the job token into .git/config by default, where any later step (module downloads, golangci-lint, tests) can read it. Nothing in this workflow needs git credentials after checkout. Refs SEC-844
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
persist-credentials: falseto everyactions/checkoutstep inci.yml.Why
By default,
actions/checkoutwrites the job'sGITHUB_TOKENinto.git/configand leaves it there for the rest of the job. Every later step can read it: module downloads, golangci-lint, and tests. A compromised dependency or action could then use the token to push code or tamper with releases. Nothing in this workflow needs git credentials after checkout.Stack
persist-credentials: falsepermissions:Part of SEC-842 (org-wide rollout).