Guard GridItem.getCellSize against stale row index during item disposal - #707
Draft
wimjongman with Copilot wants to merge 2 commits into
Draft
wimjongman with Copilot wants to merge 2 commits into
wimjongman with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: wimjongman <180969+wimjongman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix index out of bounds in GridItem.getCellSize
Guard Sep 8, 2026
GridItem.getCellSize against stale row index during item disposal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a row is disposed while scrollbar state is changing,
GridEditormay re-layout against that row and callGridItem.getCellSize. In that window, the item can already be removed fromGrid.items, causingparent.getItem(index)to throwERROR_INVALID_RANGE.Height computation hardening (
GridItem#getCellSize)Gridby row index.getHeight()from the receiver directly.indexOfCurrentItembefore any span traversal over subsequent rows; returns current cell width + own height when index is stale.Regression coverage
testDisposeItem_WithEditorAndScrollbarRemoval_DoesNotThrowinGridFixedColumn_Test.IllegalArgumentException.