Skip to content

feat(serve): default the sampling temperature to 1.0 in both thinking… - #333

Merged
linyubupa merged 1 commit into
mainfrom
feat/default-temperature-1
Nov 21, 2026
Merged

linyubupa merged 1 commit into
mainfrom
feat/default-temperature-1

Conversation

@linyubupa

Copy link
Copy Markdown
Collaborator

… states

A request that sends no sampling takes the table's values, and the instruct rows were 0.7 — flatter, shorter answers than the same model in thinking mode. Use 1.0 for both states in every family; top_p, top_k and presence_penalty stay as they were. Requests and configs that ask for a temperature still win, and an explicit temperature 0 is still greedy.

The table no longer mirrors the Qwen cards' instruct column; the comment says so.

What & why

Fixes #

Area

  • Engine, CLI or server (edge0-infer/)
  • Model asset tools (edge0-infer/tools/assets/)
  • Chat app examples (edge0-infer/examples/)
  • Model docs (docs/)
  • edge0-strata/
  • Other

How was it tested?

Checklist

  • Linked an agreed issue, or this PR is documentation-only
  • Related fixes in this area are in this pull request, one commit per fix
  • This is one of at most two open pull requests from me
  • ctest --preset cpu -L "L0|L1" passes locally in edge0-infer/ (engine changes); CI also runs these and the L2 tests not labeled local-only
  • Changes to model computation: ran the local-only answer suites (ctest --preset cpu -L local-only) on Apple silicon with i8mm (M2 or later), which CI cannot judge
  • Ran the higher test levels this change affects (see edge0-infer/docs/testing.md)
  • Added/updated tests for new behavior
  • Updated relevant docs / READMEs (incl. translations if user-facing)

… states

A request that sends no sampling takes the table's values, and the instruct
rows were 0.7 — flatter, shorter answers than the same model in thinking mode.
Use 1.0 for both states in every family; top_p, top_k and presence_penalty stay
as they were. Requests and configs that ask for a temperature still win, and an
explicit temperature 0 is still greedy.

The table no longer mirrors the Qwen cards' instruct column; the comment says so.
@github-actions github-actions Bot added the needs-info Title, issue link, test notes, or PR cap still missing label Nov 21, 2026
@github-actions

Copy link
Copy Markdown

This pull request is labeled needs-info and is not in the review queue.
The intake rules are in CONTRIBUTING.md.

  • Replace the template comment under "## How was it tested?" with the commands, platform, and results you actually ran.

@github-actions github-actions Bot added the strata edge0-strata label Nov 21, 2026
@linyubupa
linyubupa merged commit ec49171 into main Nov 21, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-info Title, issue link, test notes, or PR cap still missing strata edge0-strata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant