Skip to content

feat(desktop): send temperature 1.0 for every generation style - #335

Merged
linyubupa merged 1 commit into
mainfrom
feat/desktop-temperature-1
Nov 22, 2026
Merged

linyubupa merged 1 commit into
mainfrom
feat/desktop-temperature-1

Conversation

@linyubupa

Copy link
Copy Markdown
Collaborator

Precise sent 0.2 and Balanced 0.7; the two lower values gave shorter, flatter answers than the 35B's own recommendation of 1.0 in thinking mode, and the pickers inherited them silently. All three styles now send 1.0, the temperature fallback of buildRequest is 1.0 too, and the Settings page reads the number from the temperatures map instead of a second hardcoded list, so the label cannot drift from what is sent.

The three names stay for the picker. iOS and Android keep their own defaults; this change is the desktop app only.

What & why

Fixes #

Area

  • Engine, CLI or server (edge0-infer/)
  • Model asset tools (edge0-infer/tools/assets/)
  • Chat app examples (edge0-infer/examples/)
  • Model docs (docs/)
  • edge0-strata/
  • Other

How was it tested?

Checklist

  • Linked an agreed issue, or this PR is documentation-only
  • Related fixes in this area are in this pull request, one commit per fix
  • This is one of at most two open pull requests from me
  • ctest --preset cpu -L "L0|L1" passes locally in edge0-infer/ (engine changes); CI also runs these and the L2 tests not labeled local-only
  • Changes to model computation: ran the local-only answer suites (ctest --preset cpu -L local-only) on Apple silicon with i8mm (M2 or later), which CI cannot judge
  • Ran the higher test levels this change affects (see edge0-infer/docs/testing.md)
  • Added/updated tests for new behavior
  • Updated relevant docs / READMEs (incl. translations if user-facing)

Precise sent 0.2 and Balanced 0.7; the two lower values gave shorter, flatter
answers than the 35B's own recommendation of 1.0 in thinking mode, and the
pickers inherited them silently. All three styles now send 1.0, the temperature
fallback of buildRequest is 1.0 too, and the Settings page reads the number from
the temperatures map instead of a second hardcoded list, so the label cannot
drift from what is sent.

The three names stay for the picker. iOS and Android keep their own defaults;
this change is the desktop app only.
@github-actions github-actions Bot added the needs-info Title, issue link, test notes, or PR cap still missing label Nov 22, 2026
@github-actions

Copy link
Copy Markdown

This pull request is labeled needs-info and is not in the review queue.
The intake rules are in CONTRIBUTING.md.

  • Replace the template comment under "## How was it tested?" with the commands, platform, and results you actually ran.

@github-actions github-actions Bot added examples Chat app examples desktop Desktop chat app docs Documentation and removed needs-info Title, issue link, test notes, or PR cap still missing labels Nov 22, 2026
@linyubupa
linyubupa merged commit d2072f5 into main Nov 22, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

desktop Desktop chat app docs Documentation examples Chat app examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant