Repository navigation
feat(desktop): send temperature 1.0 for every generation style - #335
Merged
Merged
Conversation
Precise sent 0.2 and Balanced 0.7; the two lower values gave shorter, flatter answers than the 35B's own recommendation of 1.0 in thinking mode, and the pickers inherited them silently. All three styles now send 1.0, the temperature fallback of buildRequest is 1.0 too, and the Settings page reads the number from the temperatures map instead of a second hardcoded list, so the label cannot drift from what is sent. The three names stay for the picker. iOS and Android keep their own defaults; this change is the desktop app only.
|
This pull request is labeled
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precise sent 0.2 and Balanced 0.7; the two lower values gave shorter, flatter answers than the 35B's own recommendation of 1.0 in thinking mode, and the pickers inherited them silently. All three styles now send 1.0, the temperature fallback of buildRequest is 1.0 too, and the Settings page reads the number from the temperatures map instead of a second hardcoded list, so the label cannot drift from what is sent.
The three names stay for the picker. iOS and Android keep their own defaults; this change is the desktop app only.
What & why
Fixes #
Area
edge0-infer/)edge0-infer/tools/assets/)edge0-infer/examples/)docs/)edge0-strata/How was it tested?
Checklist
ctest --preset cpu -L "L0|L1"passes locally inedge0-infer/(engine changes); CI also runs these and theL2tests not labeledlocal-onlylocal-onlyanswer suites (ctest --preset cpu -L local-only) on Apple silicon with i8mm (M2 or later), which CI cannot judgeedge0-infer/docs/testing.md)