Skip to content

feat(serve): place a non-default reasoning effort before the answer b… - #338

Merged
linyubupa merged 1 commit into
mainfrom
feat/effort-position-end-default
Nov 22, 2026
Merged

linyubupa merged 1 commit into
mainfrom
feat/effort-position-end-default

Conversation

@linyubupa

Copy link
Copy Markdown
Collaborator

…y default

"effort_position" now defaults to "end": a request that asks for low or medium reasoning effort gets it in a short system turn right before the answer, so changing the effort keeps the cached conversation instead of rewriting the system prompt at the top.

"start" still puts it at the top, and an engine older than 0.1.39 (no --tail-role-token) falls back to that with the message it already printed. The comment, the run-config help, docs/DETAILS.md and the test that pinned the old default are updated.

What & why

Fixes #

Area

  • Engine, CLI or server (edge0-infer/)
  • Model asset tools (edge0-infer/tools/assets/)
  • Chat app examples (edge0-infer/examples/)
  • Model docs (docs/)
  • edge0-strata/
  • Other

How was it tested?

Checklist

  • Linked an agreed issue, or this PR is documentation-only
  • Related fixes in this area are in this pull request, one commit per fix
  • This is one of at most two open pull requests from me
  • ctest --preset cpu -L "L0|L1" passes locally in edge0-infer/ (engine changes); CI also runs these and the L2 tests not labeled local-only
  • Changes to model computation: ran the local-only answer suites (ctest --preset cpu -L local-only) on Apple silicon with i8mm (M2 or later), which CI cannot judge
  • Ran the higher test levels this change affects (see edge0-infer/docs/testing.md)
  • Added/updated tests for new behavior
  • Updated relevant docs / READMEs (incl. translations if user-facing)

…y default

"effort_position" now defaults to "end": a request that asks for low or medium
reasoning effort gets it in a short system turn right before the answer, so
changing the effort keeps the cached conversation instead of rewriting the
system prompt at the top.

"start" still puts it at the top, and an engine older than 0.1.39 (no
--tail-role-token) falls back to that with the message it already printed.
The comment, the run-config help, docs/DETAILS.md and the test that pinned the
old default are updated.
@github-actions github-actions Bot added needs-info Title, issue link, test notes, or PR cap still missing and removed needs-info Title, issue link, test notes, or PR cap still missing labels Nov 22, 2026
@github-actions

Copy link
Copy Markdown

This pull request is labeled needs-info and is not in the review queue.
The intake rules are in CONTRIBUTING.md.

  • Replace the template comment under "## How was it tested?" with the commands, platform, and results you actually ran.

@github-actions github-actions Bot added strata edge0-strata docs Documentation labels Nov 22, 2026
@linyubupa
linyubupa merged commit 3105d25 into main Nov 22, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation strata edge0-strata

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant