Skip to content

build: move to Node 24 LTS - #162

Closed
pfeerick wants to merge 2 commits into
deps/electron-45from
deps/node-24
Closed

pfeerick wants to merge 2 commits into
deps/electron-45from
deps/node-24

Conversation

@pfeerick

@pfeerick pfeerick commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Stacked on #161 (targets deps/electron-45). Moves the dev/CI toolchain from Node 22 to Node 24 LTS, the same major Electron 45 bundles, and removes the Python 3.9 CI pin.

Changes

  • Node version: .node-version 22.23.5 → 24.22.3 (latest 24 LTS, a security release); CI node-version "22" → "24" in every job. The devcontainer reads .node-version, so it follows automatically.
  • @types/node ^20 → ^24, matching Electron 45's bundled Node 24.
  • tsconfig.base.json lib es2021 → es2022, matching the existing target: es2022. The code already uses Array.prototype.at() (useFlags.ts, CloudVersionTargetForm.tsx), which only type-checked because @types/node 20 declared it globally. Electron 45's Chromium and all browsers the web build supports (Chromium with WebUSB) have it natively.
  • @typescript-eslint/* refreshed within the existing ^5.6.0 range (5.6.0 → 5.62.0), lockfile only. 5.6 rejects lib: es2022 with a parse error on every file.
  • Python pin dropped from the compile job. Root cause: Yarn adds an implicit node-gyp@latest for packages with a binding.gyp (e.g. fsevents on macOS), and the lockfile had it frozen at node-gyp 8.4.0, which needs Python's distutils (removed in Python 3.12). Refreshed to node-gyp 13.1.0, so the runner's default Python works. usb itself uses prebuilt N-API binaries and doesn't compile.

Testing

Locally on Windows with Node 24.21.0, clean node_modules:

  • yarn install --immutable (all install scripts built), fmt:check, test:types, tsc -p tsconfig.json, lint:all (0 errors, same 17 warnings), compile:production pass
  • Unit tests: only the same 28 Windows-only failures described in build: upgrade Yarn 3.1 to 4.18 #160
  • App launches under Electron 45.3.3; minimize/close IPC works when driven by Playwright 1.29

The macOS compile job without the Python pin is the main thing CI needs to confirm.

Devcontainer and docs

  • Devcontainer no longer installs python3-setuptools (only node-gyp 8 needed it). python3 stays, since node-gyp still requires Python.
  • Devcontainer installs Corepack if Node doesn't bundle it (Node 25+ no longer does), so future .node-version bumps keep working. On Node 24 this step is skipped. Not built locally (no Docker here).
  • README: node@22 → node@24, prerequisites list updated, and the outdated Node <16.10 Corepack instructions replaced.

🤖 Generated with Claude Code

pfeerick and others added 2 commits November 17, 2026 23:02
- .node-version 22.23.5 -> 24.22.3 (also used by the devcontainer),
  and CI node-version "22" -> "24"
- @types/node ^20 -> ^24, matching the Node bundled with Electron 45
- tsconfig lib es2021 -> es2022 to match target. Code already uses
  Array.prototype.at(), which only type-checked because @types/node 20
  declared it globally.
- Refresh @typescript-eslint/* within ^5 (5.6.0 -> 5.62.0); 5.6 does
  not recognise the es2022 lib
- Refresh Yarn's implicit node-gyp@latest (8.4.0 -> 13.1.0), used to
  build fsevents on macOS, and drop the Python 3.9 + setuptools CI pin
  that node-gyp 8 needed for distutils

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Drop python3-setuptools from the devcontainer; it was only needed for
  node-gyp 8's distutils. python3 stays, node-gyp still requires it.
- Install Corepack in the devcontainer if Node doesn't bundle it
  (Node 25+ no longer does), so bumping .node-version keeps working
- README: node@22 -> node@24, drop python3-setuptools from the
  prerequisites, and replace the Node <16.10 Corepack instructions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.31%. Comparing base (82baba5) to head (a906500).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           deps/electron-45     #162      +/-   ##
====================================================
- Coverage             36.35%   36.31%   -0.05%     
====================================================
  Files                   117      117              
  Lines                  4296     4296              
  Branches               1037     1037              
====================================================
- Hits                   1562     1560       -2     
- Misses                 2527     2531       +4     
+ Partials                207      205       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://983adda6.buddy-7a6.pages.dev
✅ Storybook: https://983adda6.buddy-7a6.pages.dev/storybook

@pfeerick

Copy link
Copy Markdown
Member Author

Superseded: the Node 24 commits (and the devcontainer/README follow-up) have been rebased onto #136, on top of current main. Continuing in #136.

@pfeerick pfeerick closed this Nov 18, 2026
@pfeerick
pfeerick deleted the deps/node-24 branch November 18, 2026 08:36

This branch was successfully deployed

1 active deployment
preview — a9065001 Deployed Nov 17, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant