Repository navigation
Conversation
- .node-version 22.23.5 -> 24.22.3 (also used by the devcontainer), and CI node-version "22" -> "24" - @types/node ^20 -> ^24, matching the Node bundled with Electron 45 - tsconfig lib es2021 -> es2022 to match target. Code already uses Array.prototype.at(), which only type-checked because @types/node 20 declared it globally. - Refresh @typescript-eslint/* within ^5 (5.6.0 -> 5.62.0); 5.6 does not recognise the es2022 lib - Refresh Yarn's implicit node-gyp@latest (8.4.0 -> 13.1.0), used to build fsevents on macOS, and drop the Python 3.9 + setuptools CI pin that node-gyp 8 needed for distutils Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Drop python3-setuptools from the devcontainer; it was only needed for node-gyp 8's distutils. python3 stays, node-gyp still requires it. - Install Corepack in the devcontainer if Node doesn't bundle it (Node 25+ no longer does), so bumping .node-version keeps working - README: node@22 -> node@24, drop python3-setuptools from the prerequisites, and replace the Node <16.10 Corepack instructions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## deps/electron-45 #162 +/- ##
====================================================
- Coverage 36.35% 36.31% -0.05%
====================================================
Files 117 117
Lines 4296 4296
Branches 1037 1037
====================================================
- Hits 1562 1560 -2
- Misses 2527 2531 +4
+ Partials 207 205 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
Member
Author
5 of 6 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #161 (targets
deps/electron-45). Moves the dev/CI toolchain from Node 22 to Node 24 LTS, the same major Electron 45 bundles, and removes the Python 3.9 CI pin.Changes
.node-version22.23.5 → 24.22.3 (latest 24 LTS, a security release); CInode-version"22" → "24" in every job. The devcontainer reads.node-version, so it follows automatically.@types/node^20 → ^24, matching Electron 45's bundled Node 24.tsconfig.base.jsonlibes2021 → es2022, matching the existingtarget: es2022. The code already usesArray.prototype.at()(useFlags.ts,CloudVersionTargetForm.tsx), which only type-checked because@types/node20 declared it globally. Electron 45's Chromium and all browsers the web build supports (Chromium with WebUSB) have it natively.@typescript-eslint/*refreshed within the existing^5.6.0range (5.6.0 → 5.62.0), lockfile only. 5.6 rejectslib: es2022with a parse error on every file.compilejob. Root cause: Yarn adds an implicitnode-gyp@latestfor packages with abinding.gyp(e.g.fseventson macOS), and the lockfile had it frozen at node-gyp 8.4.0, which needs Python'sdistutils(removed in Python 3.12). Refreshed to node-gyp 13.1.0, so the runner's default Python works.usbitself uses prebuilt N-API binaries and doesn't compile.Testing
Locally on Windows with Node 24.21.0, clean
node_modules:yarn install --immutable(all install scripts built),fmt:check,test:types,tsc -p tsconfig.json,lint:all(0 errors, same 17 warnings),compile:productionpassThe macOS
compilejob without the Python pin is the main thing CI needs to confirm.Devcontainer and docs
python3-setuptools(only node-gyp 8 needed it).python3stays, since node-gyp still requires Python..node-versionbumps keep working. On Node 24 this step is skipped. Not built locally (no Docker here).node@22→node@24, prerequisites list updated, and the outdated Node <16.10 Corepack instructions replaced.🤖 Generated with Claude Code