Repository navigation
fix(cloudbuild): list flag names and values in natural order - #163
Merged
Merged
Conversation
The cloud build flag picker showed flags and values in the order they were merged: global values first, then the ones a target's tags add (e.g. the colour-only languages after the rest). Sort both lists naturally, so "X9" comes before "X10". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 36.34% 36.42% +0.08%
==========================================
Files 116 116
Lines 4287 4291 +4
Branches 1037 1037
==========================================
+ Hits 1558 1563 +5
+ Misses 2522 2521 -1
Partials 207 207 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The cloud build flag picker lists flags and their values in the order they were merged. Global values come first, then the ones a target's tags add, so on a colour radio the language list ends with the colour-only languages (
… SE, UA, AR, CN, HE, …) instead of being alphabetical. The cloudbuild web UI sorts these lists; Buddy didn't.What
CloudVersionTargetFormnow sorts both the flag names and the values of the selected flag in natural order (localeComparewithnumeric: true, soX9comes beforeX10). Sorting happens where the options are displayed, so it applies however the list was built, and it doesn't overlap with #158's changes toCloudFirmwareReleasesPicker.Testing
CloudVersionTargetForm.spec.tsxopen the flag and value dropdowns and check the option order. Both fail without the fix. They read antd's rendered options directly (with aneslint-disableforno-node-access, as other specs do), since Testing Library queries don't expose the order.yarn --immutable:lint:all,fmt:check,test:typesandyarn test(288 tests) all pass.🤖 Generated with Claude Code