Repository navigation
Conversation
Add description and author to package.json, replace the placeholder mac category, and run native rebuilds through electron-builder install-app-deps so the separate @electron/rebuild devDependency can be dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 36.84% 36.84%
=======================================
Files 117 117
Lines 4310 4310
Branches 1038 1038
=======================================
Hits 1588 1588
Misses 2518 2518
Partials 204 204 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
EdgeTX Buddy has been automatically deployed to Cloudflare. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears up the electron-builder warnings in the
build-and-test-app→ Build step.descriptionandauthortopackage.json. This fixes the "description is missed" and "author is missed" warnings.electron-builder install-app-depsinstead ofelectron-rebuild, and drop the separate@electron/rebuilddevDependency. electron-builder already includes@electron/rebuildand runs it for this command, so the rebuild itself doesn't change. This fixes the "@electron/rebuild already used by electron-builder" warning and the postinstall suggestion that came with it.your.app.category.typewithpublic.app-category.utilities.The
skipped dependencies rebuild reason=npmRebuild is set to falseline still shows. It's informational, and it's what we want.Testing
yarn compile:depsrebuildsusbfor Electron 45.3.3 through electron-builder.yarn compile:productionandyarn run pack --win --dirboth pass, and the three warnings no longer appear.🤖 Generated with Claude Code