Skip to content

build: silence electron-builder metadata and rebuild warnings - #164

Open
pfeerick wants to merge 1 commit into
mainfrom
build/electron-builder-warnings
Open

pfeerick wants to merge 1 commit into
mainfrom
build/electron-builder-warnings

Conversation

@pfeerick

Copy link
Copy Markdown
Member

Summary

Clears up the electron-builder warnings in the build-and-test-app → Build step.

  • Add description and author to package.json. This fixes the "description is missed" and "author is missed" warnings.
  • Run native rebuilds with electron-builder install-app-deps instead of electron-rebuild, and drop the separate @electron/rebuild devDependency. electron-builder already includes @electron/rebuild and runs it for this command, so the rebuild itself doesn't change. This fixes the "@electron/rebuild already used by electron-builder" warning and the postinstall suggestion that came with it.
  • Replace the placeholder mac category your.app.category.type with public.app-category.utilities.

The skipped dependencies rebuild reason=npmRebuild is set to false line still shows. It's informational, and it's what we want.

Testing

  • Locally on Windows: yarn compile:deps rebuilds usb for Electron 45.3.3 through electron-builder.
  • Locally on Windows: yarn compile:production and yarn run pack --win --dir both pass, and the three warnings no longer appear.
  • CI: macOS and Linux still to check.

🤖 Generated with Claude Code

Add description and author to package.json, replace the placeholder mac category, and run native rebuilds through electron-builder install-app-deps so the separate @electron/rebuild devDependency can be dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.84%. Comparing base (670c0a4) to head (e12aff1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   36.84%   36.84%           
=======================================
  Files         117      117           
  Lines        4310     4310           
  Branches     1038     1038           
=======================================
  Hits         1588     1588           
  Misses       2518     2518           
  Partials      204      204           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://e9339725.buddy-7a6.pages.dev
✅ Storybook: https://e9339725.buddy-7a6.pages.dev/storybook

This branch was successfully deployed

1 active deployment
preview — e12aff17 Deployed Nov 18, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant