Repository navigation
feat(tabs): add testId property for tab items and improve asset loadi… - #2392
Open
sharjeelyunus wants to merge 3 commits into
Open
sharjeelyunus wants to merge 3 commits into
sharjeelyunus wants to merge 3 commits into
Conversation
…ng logic - Introduced a `testId` property for tab items to facilitate easier testing and identification of tabs. - Enhanced asset loading logic to ignore non-string configuration values, ensuring only valid asset URLs are processed. - Updated tests to validate the new `testId` functionality and asset loading behavior.
- Improved the encoding and decoding of Firestore timestamps in public storage to preserve mutable container identity. - Updated `encodePublicStorageValue` and `restorePublicStorageValue` functions to ensure containers without timestamps retain their original references. - Added a `toJson` method to `FirestoreTimestamp` for better serialization. - Introduced tests to validate the preservation of mutable containers and correct timestamp restoration behavior.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng logic
testIdproperty for tab items to facilitate easier testing and identification of tabs.testIdfunctionality and asset loading behavior.