Repository navigation
✨ [feat] dispatch: require actual host-visible worker skills - #56
Merged
Merged
Conversation
- Resolve selected lane chains from readable active skill files and scoped catalogs. - Halt dispatch before new claims; preserve evidence and stop owned workers on readiness failure. - Keep explicit setup repair and recheck availability; 56 offline suites pass.
EricTechPro
marked this pull request as ready for review
October 14, 2026 05:19
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
⏳ In review · round 1 · ✅ 5/5 AC · 56 offline suites and 13/13 hosted checks pass · head
78a4855Problem
Solution
Acceptance criteria
↳
tests/test_skills_readiness.pyexercises real isolated files and catalogs through the public CLI.↳ Literal ordered policy fixtures cover bug, feature, ux, refactor, tech-debt, tests, docs, QA-only and Review.
↳
tests/test_skill_dispatch.pycovers all four entry routes, Codex fallback, legacy dispatch and standalone build.↳ Real Codex grade-to-lane and full legacy launcher fixtures preserve unrelated processes, locks and approval bytes.
↳ Public check/fix fixture proves a successful fake npx cannot falsely report helpers installed;
--no-helperspreserves missing-readiness truth.Iteration history
Risk
🟡 Medium · launch-time gates now fail closed on unavailable helpers or unsupported activation metadata. Repair exact host-visible files or supply the effective active catalog and restart explicitly. Eight shipped skills, three lanes, approval and merge rules remain intact. Workflow runtime checks depend on workers obeying their first-operation instruction; the orchestrator's preclaim CLI is the deterministic gate. No paid host or live board run was used for validation.