Skip to content

✨ [feat] qa: add project-owned feature verifiers - #57

Merged
EricTechPro merged 1 commit into
mainfrom
codex/project-verifier
Oct 14, 2026
Merged

EricTechPro merged 1 commit into
mainfrom
codex/project-verifier

Conversation

@EricTechPro

@EricTechPro EricTechPro commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Note

⏳ In review · round 1 · ✅ 4/4 AC · head 57ace8d · all 13 checks green

Problem

  • Where: Repo-backed Onboard and issue-scoped QA
    • a. Onboard an app with accepted feature checks
    • b. Ask QA to verify a changed feature
  • Who: Projects using the existing board lanes
  • What happened: Feature checks have no shared creation/upkeep contract or reliable affected-feature map.

Solution

  • Add an optional project-owned verifier contract inside Onboard and QA, with source-backed creation, affected runs, failure classification and fresh proof.
  • Ship unfinished skill/map templates; a starter and map validation never claim passing app checks.
  • Add a read-only stdlib CLI to validate input files and select features from root-anchored owners, explicit IDs and changed paths.
  • Install the helper and detect/repair its absence through the existing setup inventory.
  • Preserve ordinary AC checks, project privacy, human-owned flows and current merge gates.

Acceptance criteria

  • Valid maps report actual map/skill/scenario hashes; malformed or missing/escaped inputs fail with JSON and documented exits.
    ↳ python3 tests/test_project_verifier.py · 9 real CLI cases; root-symlink-loop and partial-glob escape red/green witnessed.
  • Shared owners and explicit IDs select an ordered union, deleted recursive paths match, and uncovered paths remain visible without a passing-test claim.
    ↳ tests/test_project_verifier.py · shared/explicit/recursive/deleted/empty selection cases.
  • Installed helper works and setup restores it; optional creation/maintenance stays inside Onboard/QA.
    ↳ Real installed-helper test; installer 17 scenarios; full suite covers setup removal/repair.
  • Full package safety and cross-platform checks pass on the reviewed head.
    ↳ bash tests/run-safety.sh · 57 suites at 57ace8d; all 13 GitHub jobs passed.

Iteration history

Lane Done Time Details
🔨 builder ✅ Oct 13, 22:26 PDT CLI 9 cases; draft for independent review

Risk

🟡 Medium · Workflow instructions require source judgment and actual app assertions. The helper proves structure/selection only; existing projects gain no mandatory browser gate. No private app sources or proof are included.

- Add source-backed creation, upkeep and affected-run contract inside Onboard and QA.
- Ship read-only map inspection and selection with strict path containment and input hashes.
- Verify installed helper and setup repair; all 57 safety suites pass.
@EricTechPro
EricTechPro marked this pull request as ready for review October 14, 2026 05:35
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@EricTechPro
EricTechPro merged commit d4a5da4 into main Oct 14, 2026
13 checks passed
@EricTechPro
EricTechPro deleted the codex/project-verifier branch October 14, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant