[EricTechPro]

Note

⏳ In review · ✅ 6/7 AC · Closes #48 · Closes #38 · head d3082ce

Problem

• Where: hooks/guard-secrets.py → ENV_CHECK (🐛 [bug] guards: env-check allowlist lets a chained command read .env #48)
  • a. (?:\S*/)? let ;, $, {, } into the path prefix, so a second command rode along with the env-check call
  • b. \s and $ accepted a newline, a bash command separator
• Where: skills/super-board/references/run-workflow.md → "Mid-run permission prompts" (🐛 [bug] run: fresh install can't start, read helper not allowed #38)
  • a. The allowlist onboard writes left out super-board-github-read.py (and verification-ready.py), so pre-flight stopped on a prompt
  • b. Writes to .claude/super-board/ (wave lock) are a Claude Code protected path; a headless acceptEdits run can't create the lock
• Who: every project with the guard hooks; every fresh install running /super-board run

Solution

• ENV_CHECK takes path characters only in the prefix, spaces/tabs as separators, \Z as the end
• One deny test per bypass in tests/test-guard-hooks.sh, plus allow cases for direct, sh, tab and --file= calls
• Base allowlist adds the read helper in both forms, verification-ready.py and stop.sh
• New tests/test_run_allowlist.py checks every .claude/bin script called by run-workflow.md, the wave workflow and the lane skills is covered
• run-workflow.md says claude -p "/super-board run" needs bypassPermissions in an isolated sandbox; otherwise run interactively and allow the .claude folder for the session. .claude/worktrees/ is exempt from protection
• Docs: https://code.claude.com/docs/en/permission-modes#protected-paths — allow rules don't pre-approve protected-path writes

Acceptance criteria

• Both 🐛 [bug] guards: env-check allowlist lets a chained command read .env #48 bypass commands return deny
  ↳ tests/test-guard-hooks.sh env-check cases; failed against origin/main's hook, pass now
• Legit env-check calls (names only, --file with a local dotenv) still allow
  ↳ existing + new allow cases in tests/test-guard-hooks.sh
• One deny case per bypass
  ↳ semicolon, substitution, brace, newline before/after/inside, trailing newline
• Allowlist lists super-board-github-read.py in both forms
  ↳ run-workflow.md base list; onboard writes this list
• A test asserts every pre-flight and lane script is allowlisted
  ↳ tests/test_run_allowlist.py (red before the doc fix)
• run-workflow.md states whether claude -p "/super-board run" is supported
  ↳ "Headless runs" paragraph
• A fresh install drains a headless wave
  ↳ not verified: needs a live dogfood run with bypassPermissions in a sandbox · Eric

Iteration history

Lane	Done	Time	Details
🔨 builder	✅	Oct 18	bash tests/run-safety.sh → 58/58 suites · d3082ce

Risk

🟢 Low · regex narrowing (legit calls keep their shape) plus allowlist and docs.

🤖 Generated with Claude Code

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →