[EricTechPro]

Note

⏳ In review · round 1 · ✅ 4/4 AC · Closes #62 · Closes #63

Problem

• Where: scripts/super-board-github-read.py (diff reads) and scripts/super-board-approval.py (human approval)
  • a. github-read: valid diffs fail as 'diff hunk data missing' and halt the board #62: a PR adds a file whose lines hold VT, FF, U+2028/9, NEL or a lone \r
  • b. approval: done never counts on a board whose PRs target a non-default branch #63: a board's PRs target a non-default base (e.g. staging)
• Who: any board running the merge gate or human-gated merges
• What happened:
  • github-read: valid diffs fail as 'diff hunk data missing' and halt the board #62: the valid diff reads as diff hunk data missing, and after 3 attempts the board halts (exit 79)
  • approval: done never counts on a board whose PRs target a non-default branch #63: a trusted done never counts; approval answers request issue is not linked to this PR

Solution

• github-read splits a diff on \n only; splitlines() also broke on VT, FF, U+2028 and friends
• github-read decodes gh output by hand; text=True universal newlines turned a lone \r into \n
• approval reads baseRefName, body and defaultBranchRef in the same head-pinned snapshot
• Off the default base, approval also takes same-repo close/fix/resolve #N references from the body; other-repo refs are ignored

Acceptance criteria

• A diff with VT, FF, FS, NEL, U+2028/9, a lone CR and CRLF in changed lines passes on the first read
  ↳ tests/test_github_reads.py test_diff_lines_with_line_like_characters_are_complete_evidence (fails on main)
• A PR into a non-default base with Closes #N in its body approves
  ↳ tests/test_approval.py test_non_default_base_takes_closing_keywords_from_body (fails on main)
• No keyword, other-repo refs and default-base body keywords still do not link
  ↳ tests/test_approval.py GitHubTests non-default/default-base cases
• Offline suite green
  ↳ bash tests/run-safety.sh → PASS: 57 safety suites

Iteration history

Lane	Done	Time	Details
🔨 builder	✅	Oct 18	bfbef1c #62 · 9802af6 #63

Risk

🟢 Low · diff validation only gets more permissive about in-line characters; approval adds a body fallback only when base differs from default, all other checks unchanged. Closing-keyword parsing still exists separately in the merge gate and pre-flight (not unified here).

Closes #62
Closes #63

🤖 Generated with Claude Code

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →