Repository navigation
Offer the GRCh37 genetic map as a download after a yes - #8
Merged
Merged
Conversation
The owner chose (N124 A) not to bundle the HapMap-derived GRCh37 map, since no license is stated for it, and to let the app fetch it from its source instead. The Kits screen now names the source, size and missing license, downloads only after a yes, checks the archive against a pinned size and SHA-256, and keeps chromosomes 1 to 22 and X with a note on where they came from. Comparisons use it when both raw files are on GRCh37; the demo keeps the approximate rule because its positions are invented. Tested with made-up archives in Vitest, and once by hand against the real archive. The card hasn't been clicked in the built app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes K653 (owner's N124 A). A Genetic map card on the Kits screen names the source (Beagle genetic maps, University of Washington), the size and the missing license, and downloads only after a yes. The host checks the pinned size and SHA-256, unzips chromosomes 1 to 22 and X into the app's folder with a SOURCE.md, and uses the map when both raw files are on GRCh37. The demo keeps the approximate rule.
Tested: 275 tests, typecheck, leak check. A real-archive install was checked by hand once (chromosome 1 at 286 cM), not in CI. Not clicked in the built app.
🤖 Generated with Claude Code