Skip to content

Sync generated client with Extensions v2 contract - #343

Merged
admdly merged 4 commits into
mainfrom
rfc-0001-contract-tidy
Sep 23, 2026
Merged

admdly merged 4 commits into
mainfrom
rfc-0001-contract-tidy

Conversation

@admdly

@admdly admdly commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Site-side co-migration for FOSSBilling/api#252 (same branch name). Must land together — the API breaks ?status=/offset lists this PR migrates away from.

What changed

  • Spec refreshed from the local API build and client regenerated (openapi/extensions-v2.json + generated/).
  • lib/api/client.ts: offset walker → cursor walker, status: → scope: on developer lists, new relistExtension wrapper.
  • test/extensions-api.test.ts: moderator-list block rewritten for cursors + relist coverage. Admin pages needed no changes (whole-list wrappers).

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread test/extensions-api.test.ts
Comment thread src/lib/api/client.ts
@admdly admdly changed the title Sync generated client with Extensions v2 contract tidy Sync generated client with Extensions v2 contract Sep 23, 2026
@admdly admdly self-assigned this Sep 23, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Auto-approved: Migrations the generated Extensions v2 client to the new cursor-paginated contract, swapping offset walking for cursor walking and status for scope on developer lists, plus adding a relistExtension wrapper. Bounded client sync required by the API change; tests updated to pin cursor behavior.

Re-trigger cubic

@admdly
admdly merged commit 066b82b into main Sep 23, 2026
9 checks passed
@admdly
admdly deleted the rfc-0001-contract-tidy branch September 23, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant