Power Logging - #317
Open
SpeedSlicer wants to merge 8 commits into
Open
Power Logging#317SpeedSlicer wants to merge 8 commits into
SpeedSlicer wants to merge 8 commits into
Conversation
1023941311414
left a comment
1023941311414
left a comment
Collaborator
There was a problem hiding this comment.
I left a few comments on the files. Also, if it's not too much work, could you refer to energy consumption as "totalEnergy" instead of "motorDraw," and to power as "motorPower" instead of "motorWattage"? I just want to use the standard physics terms.
| .toArray(); | ||
| inputs.driveDrawJoules += inputs.driveAppliedVoltage * inputs.driveCurrentAmps * 0.02; | ||
| inputs.steerDrawJoules += inputs.steerAppliedVoltage * inputs.steerCurrentAmps * 0.02; | ||
| inputs.totalDrawJoules += inputs.driveDrawJoules + inputs.steerDrawJoules; |
Collaborator
There was a problem hiding this comment.
This variable should just have its value set, not incremented
Collaborator
There was a problem hiding this comment.
See comments in real IO
1023941311414
requested changes
Apr 19, 2026
…at happens next is shocking!
Collaborator
Author
|
and i responded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was added?
Logs for Wattage and Total Power Drawn for each subsystem in use (ignoring climber, we dont care about it)