Skip to content

Claim Visibility Override - #320

Open
DerSimeon wants to merge 1 commit into
FTBTeam:mainfrom
DerSimeon:feature/claim-visibility-override
Open

DerSimeon wants to merge 1 commit into
FTBTeam:mainfrom
DerSimeon:feature/claim-visibility-override

Conversation

@DerSimeon

Copy link
Copy Markdown

This small PR adds an Override to force the claim visibility for teams

@CLAassistant

CLAassistant commented Sep 22, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@desht

desht commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

My only concern with this approach is that the server quietly reverts any attempt to change the visibility property if the override flag has been set. Because there's no feedback to players, this could lead to player confusion and complaints to either the server admin or ourselves, which isn't ideal.

I'd prefer if the fact the visibility can't be changed was made as clear as possible to player attempting to change it...

@desht

desht commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

Also, if the change is reverted (i.e. denied), it shouldn't be necessary to resync the team's chunks, right? Since nothing's actually being changed.

@DerSimeon

Copy link
Copy Markdown
Author

I'd prefer if the fact the visibility can't be changed was made as clear as possible to player attempting to change it...

Any suggestions on where I could implement that?

Also, if the change is reverted (i.e. denied), it shouldn't be necessary to resync the team's chunks, right? Since nothing's actually being changed.

The UI would still show that the setting has been changed even though in the background it has been reverted. That's why I send a resync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants