fix: validate structured output with strict models - #16
Merged
Conversation
Thaw immutable JSON containers before Pydantic validation while preserving the frozen raw result. Make the live example deterministic and add strict nested streaming coverage. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-davidgu
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Structured output notifications are frozen into
mappingproxyand tuple containers before local adaptation. Strict Pydantic models reject those container types even when the JSON values are valid. The previous example prompt also invited a repository review, causing tool loops and timeouts instead of a bounded demonstration.Validation
pytest tests/test_v5_public_models.py tests/test_v5_streaming_core.py -q(131 passed, 4 skipped)pytest -q(1498 passed, 15 skipped)ruff check .mypypyrightexamples/structured_output_model.pyagainst production