Fix/ci node22 audit - #494
Merged
Merged
Conversation
Rewritten display, connections and charging pages; new troubleshooting page linked from the overview. Screen images are generated from the firmware (FactoryOptic-FAC14 tools/render_screens.py) and live under static/images/qtc/v2/. Old photographs are left in place.
- Stop tracking node_modules (9,295 files); it was committed despite .gitignore. - CI: workflow pinned Node 16, which ESLint 9 cannot run on, so every run on master has failed since Aug 2025. Matrix is now Node 22/24 and actually uses the matrix version. Bump checkout, setup-node, stale and codeql actions to current majors. - Node 20 is end-of-life; pin 22.23.2 in netlify.toml, .nvmrc and package.json engines. - Home template read package.json via resources.Get, which only sees assets/, so production builds failed with "no data to transform". Use os.ReadFile. - Replace hugo-installer (pulls decompress, critical, no fixed version) with hugo-extended 0.155.3. Hugo 0.124.1 -> 0.155.3; generated page set is identical. 0.156+ removes .Site.Author which rss.xml still uses. - markdownlint-cli2 0.18 -> 0.23; configure MD001 to ignore the front-matter title since pages start at h3 by convention. - npm overrides for adm-zip and js-yaml 4.x. npm audit: 27 -> 0. - Dev server renders to memory so builds into public/ can't be served mid-session.
✅ Deploy Preview for factoryoptic ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brief explanation of the proposed changes.
Basic example
Include a basic example, screenshots, or links.
Motivation
Why are we doing this? What use cases does it support? What is the expected outcome?
Checks
npm run test