Skip to content

ci: repin dtolnay/rust-toolchain to the current v1 (upstream input-handling fix) - #956

Merged
rapp992 merged 1 commit into
mainfrom
fix/rust-toolchain-pin
Oct 9, 2026
Merged

rapp992 merged 1 commit into
mainfrom
fix/rust-toolchain-pin

Conversation

@rapp992

@rapp992 rapp992 commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

What changed

The six dtolnay/rust-toolchain SHA pins in ci.yml, release.yml and security-nightly.yml move from 7e38f4b to e2a55d2, which is what the v1 tag (and master) now points to.

Why. Upstream moved v1 to merge dtolnay/rust-toolchain#187, a security hardening of the action itself ("Safely handle action inputs"):

  • multi-line-safe GITHUB_OUTPUT writes, using a delimiter that adapts to the input;
  • rustup flags built as an argv array under set -f, instead of string-concatenated command lines.

zizmor's online ref-version-mismatch audit now fails the Docs & paths lint step on every PR. Our pins are commented # v1 but point at the old head. This first showed up on #954.

e2a55d2 is a descendant of the old pin (git merge-base --is-ancestor holds), and the diff touches only action.yml (+29/−20). I read the whole diff.

Verification

  • make lint-ci passes locally: actionlint, plus zizmor (offline) with no findings.
  • The online zizmor audit only runs in CI, so this PR's Docs & paths job is the proof.

Gates skipped: the full make verify was not run. This is a workflow-pin-only change, and CI runs everything.

Reviews

Claude: none. This is a mechanical pin update, and I reviewed the upstream diff above. Codex: absent.

Capability spec

  • No capability spec covers this area.

Security surface

  • Names the surface: CI workflows are on it. The change adopts an upstream injection-hardening fix in a pinned action.

Invariants touched: none.

Escalations


Must be merged by a human — nothing here merges autonomously.

🤖 Generated with Claude Code

https://claude.ai/code/session_017phewNxcFMxpU3ntX2TKek


Generated by Claude Code

Upstream moved the v1 tag to e2a55d2 (dtolnay/rust-toolchain#187,
"Safely handle action inputs": multi-line-safe GITHUB_OUTPUT writes and
argv-array rustup flags instead of string-built command lines). zizmor's
online ref-version-mismatch audit now fails every PR's lint step because
our six SHA pins, commented '# v1', point at the old head 7e38f4b. The
new commit descends from the old pin and changes only action.yml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017phewNxcFMxpU3ntX2TKek
@rapp992
rapp992 merged commit d7ef4e6 into main Oct 9, 2026
16 checks passed
@rapp992
rapp992 deleted the fix/rust-toolchain-pin branch October 9, 2026 06:00
rapp992 pushed a commit that referenced this pull request Oct 9, 2026
rapp992 pushed a commit that referenced this pull request Oct 9, 2026
rapp992 pushed a commit that referenced this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants