fix(profiles): include sync with archive workflows - #1663
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCustom profiles that select ChangesArchive Sync Dependency
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The change ensures archive workflows install their required sync workflow and updates migration and reporting behavior accordingly; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Status
LGTM.
What was wrong
Custom profiles could select archive or bulk archive without selecting sync. The generated archive workflow still called the missing sync workflow, so archive could stop or improvise the main-spec update. Legacy Codex prompt migration could create the same broken combination.
How it was fixed
Profile resolution now includes sync whenever either archive workflow is selected without it. The same dependency resolution is applied when legacy Codex prompts are migrated. Existing core profiles and custom profiles that already include sync are unchanged.
The profile editor keeps custom profiles user-owned: accepting an unchanged effective selection does not convert it to the core preset or rewrite its raw workflow list. Update guidance reports the effective workflow set, so it does not claim that an installed dependency is missing.
Replication / proof
Notes / nits
This completes an existing workflow dependency without changing archive execution, templates, schemas, or file formats. No changeset is included because this routine bug fix follows the normal release cadence.
Related prior approach: #1443 changes archive templates to add a manual fallback. It is currently conflicting and broader in scope; this PR instead ensures the workflow dependency is installed at the shared profile boundary.
Fixes #1650
Summary by CodeRabbit
Bug Fixes
Tests